Page MenuHomePhabricator
Create Task
Maniphest T322278

MediaWiki core should pass Phan on PHP 8.1
Closed, ResolvedPublic
Actions

Description

I'm not sure if simultaneous support for running Phan on PHP 7.4 and PHP 8.1 is necessary. If it is, some ugly hacks will be needed since the versions contradict each other.

I have a patch which reduces the number of failures from 27 to 6.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Respond to some messages from Phan on PHP 8.1mediawiki/coreREL1_39+49 -22
Fix the remaining Phan failures on PHP 8.1mediawiki/coreREL1_39+7 -3
Improve LocalisationCache post-merge validation checkmediawiki/coreREL1_39+6 -6
Zuul: [mediawiki/core] Add PHP 8.1 phan jobintegration/configmaster+4 -1
Fix the remaining Phan failures on PHP 8.1mediawiki/coremaster+9 -4
Improve LocalisationCache post-merge validation checkmediawiki/coremaster+6 -6
Respond to some messages from Phan on PHP 8.1mediawiki/coremaster+52 -23
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT396296 Upgrade symfony/* to PHP 8.1 versions
 ResolvedReedyT373753 Drop symfony/polyfill-php 73-81 from mediawiki-vendor
 StalledNoneT255792 Quibble runs core:unit tests twice!
 OpenNoneT232915 Red-green in PHPUnit code coverage are hard to read
 OpenNoneT376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
 OpenNoneT379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
 ResolvedReedyT378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
 ResolvedKrinkleT358666 Drop PHP 8.1 support from MediaWiki
 ResolvedKrinkleT360995 Migrate Wikimedia production from PHP 8.1 to PHP 8.3
 ResolvedJdforrester-WMFT353362 Make PHP 8.3 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
 ResolvedJdforrester-WMFT352085 Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
 ResolvedJdforrester-WMFT360560 Make PHP 8.2 voting on development branch of Wikibase
 ResolvedLucas_Werkmeister_WMDET324202 Remove use of utf8_encode and utf8_decode in Wikibase
 ResolvedNoneT353161 [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
 ResolvedJdforrester-WMFT360709 Make PHP 8.2 voting on development (master) branch of Math extension
 ResolvedDaimonaT381728 Use PHP 8.3 in MediaWiki-Docker
 ResolvedJdforrester-WMFT398491 Move CI images to WMF PHP 8.3 packages
 DeclinedNoneT401255 Switch PHP 8.3 image of MediaWiki-Docker from Sury to WMF
 ResolvedScott_FrenchT401254 Upgrade mw-debug/next to PHP 8.3
 ResolvedScott_FrenchT401252 Configure title-case consistency mapping for PHP 8.1 -> 8.3 transition
 ResolvedScott_FrenchT399884 Configure production MediaWiki image builds for PHP 8.3
 ResolvedcscottT401855 ☂ PHP 8.3 issues found during WMF rollout
 ResolvedScott_FrenchT402424 PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /srv/monitoring/lib.php on line 99
 DuplicatePRODUCTION ERRORNoneT403514 Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 12860)
 ResolvedPRODUCTION ERRORMichaelT407403 Error: Invalid serialization data for DatePeriod object
 ResolvedPRODUCTION ERRORMichaelT408852 PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated
 ResolvedMichaelT401005 Investigate Production Errors from ComputedUserImpactLookup::getPageViewData
 DuplicatePRODUCTION ERRORNoneT409248 PHP Warning: Trying to access array offset on null
 Resolved• TgrT402597 Exploratory testing on PHP 8.3 for MediaWiki Platform Team components
 ResolvedNoneT402804 Exploratory testing on PHP 8.3 for MediaWiki authentication stack
 ResolvedDAlangi_WMFT403484 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Login
 Resolved• TgrT403485 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Central session
 ResolvedDAlangi_WMFT403486 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Signup
 Resolved• TgrT403487 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: OAuth
 Resolved• TgrT403488 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: 2FA
 ResolvedAtienoT402809 Exploratory testing on PHP 8.3 for MediaWiki Interfaces Team components
 OpenNoneT402810 Exploratory testing on PHP 8.3 for Content Transform Team components
 ResolvedbrouberolT403110 Prepare dumps-on-k8s (mediawiki-dumps-legacy) for migration to PHP 8.3
 ResolvedScott_FrenchT403655 Configure mw-next-routing for the PHP 8.3 migration
 ResolvedScott_FrenchT403657 Configure the WikimediaEvents extension for the PHP 8.3 migration
 ResolvedScott_FrenchT403284 Migrate production Shellbox services to PHP 8.3
 ResolvedScott_FrenchT403283 Prepare PHP 8.3 service images for Shellbox
 ResolvedScott_FrenchT398246 Prepare PHP 8.3 production images
 ResolvedScott_FrenchT398245 Prepare WMF PHP 8.3 packages for bullseye
 ResolvedKrinkleT400109 Ensure MediaWiki-Core-Profiler works with php-xhprof 2.x (PHP 8.3)
 ResolvedKrinkleT401152 Switch wmf-config/Profiler from Tideways to XHProf
 ResolvedScott_FrenchT403772 Migrate parsoidtest1001 to PHP 8.3
 ResolvedKrinkleT405031 lcobucci/clock needs upgrading for PHP 8.3
 Resolved• TgrT363639 web-auth/webauthn-lib must be upgraded to 4+ for PHP 8.2+ support
 ResolvedScott_FrenchT405955 MediaWiki on PHP 8.3 production workload migration
 ResolvedjnucheT411277 Patchdemo wiki creation fails due to PHP 8.1 not supported by MW
 ResolvedJdforrester-WMFT411372 wikilambda-catalyst-end-to-end broken due to new version of composer after PHP 8.1 -> 8.3 migration
 ResolvedBUG REPORT• bd808T411235 Beta cluster scap using php8.1 container; php8.2 is now required
 ResolvedReedyT380185 Prepare for newer geoip2/geoip2 library
 ResolvedReedyT338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
 Resolvedseanleong-WMDET379930 Use WeakMap instead of an array in RestrictedEntityLookupFactory
 StalledNoneT334726 Use return type `never` in Wikibase
 OpenNoneT328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
 ResolvedLucas_Werkmeister_WMDET328741 Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"
 ResolvedDaimonaT342110 Upgrade to PHPUnit 9.6
 ResolvedDaimonaT342259 Move MediaWikiIntegrationTestCase setup and teardown away from run()
 ResolvedDaimonaT342301 Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking
 OpenNoneT332865 PHPUnit data providers should be simple static functions that return plain data
 ResolvedUmherirrenderT337130 Make PHPUnit dataProvider LexemeFieldTestBase::getTestData static (WikibaseLexemeCirrusSearch extension)
 ResolvedArendpieterT337135 Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static
 ResolvedUmherirrenderT337144 Make PHPUnit dataProvider static in AbuseFilter tests
 ResolvedUmherirrenderT337155 Make PHPUnit dataProvider static in ReadingLists tests
 Resolved• mszaboT337156 Make PHPUnit dataProvider static in IPInfo tests
 ResolvedtstarlingT337157 Make PHPUnit dataProvider static in LoginNotify tests
 ResolvedUmherirrenderT337158 Make PHPUnit dataProvider static in Flow tests
 ResolvedDreamy_JazzT337159 Make PHPUnit dataProvider static in CheckUser tests
 ResolvedDreamy_JazzT346044 Remove CheckUserUnionQueryBuilder
 ResolvedPhysikerweltT337160 Make PHPUnit dataProvider static in Math tests
 Resolved• TgrT337161 Make PHPUnit dataProvider static in OAuth tests
 ResolvedUmherirrenderT337162 Make PHPUnit dataProvider static in ProofreadPage tests
 ResolvedUmherirrenderT337163 Make PHPUnit dataProvider static in CirrusSearch tests
 ResolvedNoneT337164 Make PHPUnit dataProvider static in FileImporter tests
 ResolvedUmherirrenderT337165 Make PHPUnit dataProvider static in GrowthExperiments tests
 ResolvedNoneT337166 Make PHPUnit dataProvider static in CampaignEvents tests
 ResolvedNoneT371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
 ResolvedkarapayneWMDET337154 Make PHPUnit dataProvider static in Wikibase tests
 ResolvedAudreyPenven_WMDET380604 Make provideLuaData static
 ResolvedAudreyPenven_WMDET380605 Make EntityMetaTagsCreatorTestCase's provideTestGetMetaTags dataProvider static
 ResolvedLucas_Werkmeister_WMDET337153 Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
 ResolvedLucas_Werkmeister_WMDET337151 Make PHPUnit dataProvider static in WikibaseLexeme tests
 ResolvedUmherirrenderT337152 Make PHPUnit dataProvider static in WikibaseMediaInfo tests
 ResolvedthiemowmdeT337150 Make PHPUnit dataProvider static in Wikidata.org tests
 ResolvedLucas_Werkmeister_WMDET337148 Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
 ResolvedUmherirrenderT393065 Make PHPUnit dataProvider on ExtensionJsonTestBase static
 ResolvedUmherirrenderT393079 Make PHPUnit dataProvider static in CommunityConfiguration tests
 ResolvedUmherirrenderT393080 Make PHPUnit dataProvider static in AutoModerator tests
 ResolvedUmherirrenderT393081 Make PHPUnit dataProvider on AbstractChangesListSpecialPageTestCase static
 ResolvedUmherirrenderT393082 Make PHPUnit dataProvider on OutputTransformStageTestBase static
 ResolvedUmherirrenderT393084 Make PHPUnit dataProvider on TypeDefTestCaseTrait static
 Resolved• mszaboT393115 Make PHPUnit dataProvider on PasswordTestCase static
 ResolvedxSavitarT393122 Make PHPUnit dataProvider on BundleSizeTestBase static
 ResolvedUmherirrenderT393132 Make PHPUnit dataProvider on RevisionRecordTests static
 ResolvedUmherirrenderT393207 Make PHPUnit dataProvider on ExtensionServicesTestBase static
 ResolvedUmherirrenderT393219 Make PHPUnit dataProvider on RestStructureTest static
 ResolvedUmherirrenderT410731 Fix all Wikimedia production code and MW extensions PHPUnit tests data providers real providers (and use static methods)
 OpenNoneT345481 Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing
 OpenNoneT422866 Migrate parser tests to new phpunit:config mechanism
 ResolvedArendpieterT358394 Stop using internal PHPUnit code in Scribunto
 OpenNoneT363064 MediaWiki.Commenting.MissingCovers.MissingCovers does not support PHPUnit 10.x attributes
 ResolvedUmherirrenderT363641 IPUtils: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
 Resolved• larissagauliaT363650 Minify: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
 ResolvedUmherirrenderT362858 equivset: Expecting E_ERROR and E_USER_ERROR is deprecated
 ResolvedJdforrester-WMFT395743 Use of package ockcyp/covers-validator in libaries is not compatible with PHPUnit 10
 OpenNoneT420851 Use of ExtensionJsonTestBase causes "Empty data set provided by data provider" failures under PHPUnit 10
 OpenNoneT420853 Use of AbstractSchemaTestBase causes "Empty data set provided by data provider" failures under PHPUnit 10
 OpenNoneT420854 LuaEngineTestBase causes "Empty data set provided by data provider" failures for lua errors under PHPUnit 10
 OpenNoneT420856 Use of HTMLFormFieldTestCase causes "Empty data set provided by data provider" failures under PHPUnit 10
 OpenNoneT420857 Skipping in EnWikiFormulaeTest does not work under PHPUnit 10
 OpenNoneT420859 EntityHandlerTestCase causes invalid data provider failures under PHPUnit 10
 OpenNoneT420860 OutputTransformStageTestBase causes invalid data provider failures under PHPUnit 10
 OpenUmherirrenderT421178 Fix PHPUnit 10 deprecation notice "Providing invalid named argument $... for method ... is deprecated and will not be supported in PHPUnit 11.0." in wmf deployed code
 ResolvedJdforrester-WMFT319055 Upgrade to psr/container 2.x
 ResolvedJdforrester-WMFT328921 Drop PHP 7.4 and PHP 8.0 support from MediaWiki
 ResolvedKrinkleT319432 Migrate WMF production from PHP 7.4 to PHP 8.1
 ResolvedJdforrester-WMFT316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
 ResolvedtstarlingT322278 MediaWiki core should pass Phan on PHP 8.1

Event Timeline

tstarling created this task.Nov 3 2022, 2:31 AM
gerritbot added a comment.Nov 3 2022, 2:33 AM

Change 852326 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Respond to some messages from Phan on PHP 8.1

https://gerrit.wikimedia.org/r/852326

gerritbot added a project: Patch-For-Review.Nov 3 2022, 2:33 AM
Reedy removed Jdforrester-WMF as the assignee of this task.Nov 3 2022, 2:46 AM
Reedy edited projects, added phan, MediaWiki-General; removed Continuous-Integration-Config.
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.
Reedy removed subscribers: Tacsipacsi, hashar.
hashar added a subscriber: Daimona.Nov 3 2022, 11:08 AM

+ @Daimona our Phan expert.

I have triggers Phan under PHP 8.1 by commenting check experimental on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/852326/3 which yields:

includes/htmlform/fields/HTMLTimezoneField.php:88
  PhanImpossibleTypeComparison Impossible attempt to check if $identifiers of type array is identical to false of type false

includes/language/LocalisationCache.php:1029
  UnusedPluginSuppression Plugin BuiltinSuppressionPlugin suppresses issue PhanTypePossiblyInvalidDimOffset on this line but this suppression is unused or suppressed elsewhere

includes/libs/MappedIterator.php:79
  PhanUndeclaredMethod Call to undeclared method \Traversable::current

includes/libs/filebackend/fileiteration/FileBackendStoreShardListIterator.php:68
  PhanUndeclaredMethod Call to undeclared method \Traversable::current

includes/parser/Parser.php:3538
  PhanPluginRedundantAssignment Assigning null to variable $revisionRecord which already has that value

includes/password/Pbkdf2PasswordUsingHashExtension.php:49
  PhanRedundantCondition Redundant attempt to cast $hash of type string to string

Some have @phan-suppress-next-line indentation albeit with a different error name. Maybe the names are slightly different when run under php 8+ or they hit some differences. The last one explicitly states the cast is no more necessary on PHP 8.0+.

Under PHP 8.0 there are a lot of PhanUndeclaredClassAttribute Reference to undeclared class \ReturnTypeWillChange in an attribute (annotations added via T289879). Maybe we need a stub for this class when running under PHP 8.0?

tstarling added a comment.Nov 3 2022, 11:17 AM

Yes, those are the 6 errors I mentioned. My analysis:

  • HTMLTimezoneField: It was discussed at https://github.com/phan/phan/issues/3162. It just needs a suppression, but the issue name has changed.
  • LocalisationCache: unused suppression but it is needed by PHP 7.4.
  • MappedIterator, FileBackendStoreShardListIterator: obviously a false positive since the type is Iterator not Traversable. Ideally I'd like to tell Phan what the type is, but @method didn't seem to work. We may need to add a variable. Or just suppress.
  • Parser: No idea what Phan is thinking here. $revisionRecord is false.
  • Pbkdf2PasswordUsingHashExtension: This check is needed until PHP 8.0 as I noted in a comment on my patch. Needs a suppression.
gerritbot added a comment.Nov 4 2022, 12:07 AM

Change 852326 merged by jenkins-bot:

[mediawiki/core@master] Respond to some messages from Phan on PHP 8.1

https://gerrit.wikimedia.org/r/852326

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2022, 12:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 4 2022, 1:00 AM
gerritbot added a comment.Nov 9 2022, 12:56 AM

Change 854649 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Improve LocalisationCache post-merge validation check

https://gerrit.wikimedia.org/r/854649

gerritbot added a project: Patch-For-Review.Nov 9 2022, 12:56 AM
gerritbot added a comment.Nov 9 2022, 2:15 AM

Change 854653 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Fix the remaining Phan failures on PHP 8.1

https://gerrit.wikimedia.org/r/854653

gerritbot added a comment.Nov 9 2022, 10:20 AM

Change 854649 merged by jenkins-bot:

[mediawiki/core@master] Improve LocalisationCache post-merge validation check

https://gerrit.wikimedia.org/r/854649

gerritbot added a comment.Nov 9 2022, 10:21 AM

Change 854653 merged by jenkins-bot:

[mediawiki/core@master] Fix the remaining Phan failures on PHP 8.1

https://gerrit.wikimedia.org/r/854653

Maintenance_bot removed a project: Patch-For-Review.Nov 9 2022, 10:30 AM
gerritbot added a comment.Nov 9 2022, 5:58 PM

Change 855046 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/core] Add PHP 8.1 phan job

https://gerrit.wikimedia.org/r/855046

gerritbot added a project: Patch-For-Review.Nov 9 2022, 5:58 PM
tstarling added subscribers: Krinkle, hashar.Nov 9 2022, 10:45 PM
In T322278#8365888, @hashar wrote:

Under PHP 8.0 there are a lot of PhanUndeclaredClassAttribute Reference to undeclared class \ReturnTypeWillChange in an attribute (annotations added via T289879). Maybe we need a stub for this class when running under PHP 8.0?

I talked with @Krinkle about this yesterday. He suggested not running Phan on PHP 8.0. Just run PHPUnit only.

gerritbot added a comment.Nov 9 2022, 11:01 PM

Change 855046 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Add PHP 8.1 phan job

https://gerrit.wikimedia.org/r/855046

Stashbot added a comment.Nov 9 2022, 11:02 PM

Mentioned in SAL (#wikimedia-releng) [2022-11-09T23:02:25Z] <James_F> Zuul: [mediawiki/core] Add PHP 8.1 phan job for T322278

Jdforrester-WMF closed this task as Resolved.Nov 9 2022, 11:04 PM
Jdforrester-WMF assigned this task to tstarling.
Reedy mentioned this in T326367: phan PHP 8.1 failures on MW 1.39.Jan 5 2023, 10:57 PM
Reedy removed a project: Patch-For-Review.Jan 5 2023, 11:13 PM
gerritbot added a comment.Jan 5 2023, 11:20 PM

Change 875924 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_39] Improve LocalisationCache post-merge validation check

https://gerrit.wikimedia.org/r/875924

gerritbot added a project: Patch-For-Review.Jan 5 2023, 11:20 PM
gerritbot added a comment.Jan 5 2023, 11:29 PM

Change 875925 had a related patch set uploaded (by Umherirrender; author: Tim Starling):

[mediawiki/core@REL1_39] Respond to some messages from Phan on PHP 8.1

https://gerrit.wikimedia.org/r/875925

gerritbot added a comment.Jan 5 2023, 11:32 PM

Change 875924 merged by jenkins-bot:

[mediawiki/core@REL1_39] Improve LocalisationCache post-merge validation check

https://gerrit.wikimedia.org/r/875924

gerritbot added a comment.Jan 5 2023, 11:39 PM

Change 876047 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_39] Fix the remaining Phan failures on PHP 8.1

https://gerrit.wikimedia.org/r/876047

gerritbot added a comment.Jan 5 2023, 11:51 PM

Change 876047 merged by jenkins-bot:

[mediawiki/core@REL1_39] Fix the remaining Phan failures on PHP 8.1

https://gerrit.wikimedia.org/r/876047

ReleaseTaggerBot added a project: MW-1.39-notes.Jan 6 2023, 12:01 AM
gerritbot added a comment.Jan 6 2023, 12:30 AM

Change 875925 merged by jenkins-bot:

[mediawiki/core@REL1_39] Respond to some messages from Phan on PHP 8.1

https://gerrit.wikimedia.org/r/875925

Umherirrender mentioned this in T353276: Make Phan on PHP 8.1 voting for wmf-deployed extensions/skins.Dec 12 2023, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 12 2023, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits