Page MenuHomePhabricator
Create Task
Maniphest T322293

Make pygments syntaxhighlighting limits configurable
Closed, ResolvedPublic
Actions

Description

Especially for 3rd parties but also for future maintainability it is a good idea to have our highlighting limits be configurable instead of const's in the class.

Details

SubjectRepoBranchLines +/-
Make the code size limit for highlighting configurablemediawiki/extensions/SyntaxHighlight_GeSHimaster+31 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.Nov 3 2022, 10:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2022, 10:07 AM
TheDJ added a parent task: T104109: No syntax highlight for large JavaScript/CSS/Lua/API pages.Nov 3 2022, 10:07 AM
gerritbot added a comment.Nov 3 2022, 10:08 AM

Change 852282 had a related patch set uploaded (by TheDJ; author: Alex44019):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Make the code size limit for highlighting configurable

https://gerrit.wikimedia.org/r/852282

gerritbot added a project: Patch-For-Review.Nov 3 2022, 10:08 AM
TheDJ renamed this task from Make pygments limits configurable to Make pygments syntaxhighlighting limits configurable.Nov 3 2022, 10:09 AM
TheDJ assigned this task to Alex44019.
TheDJ triaged this task as Low priority.
Pcj subscribed.Nov 7 2022, 2:53 PM
lilydjwg subscribed.Nov 20 2022, 11:39 AM
gerritbot added a comment.Nov 26 2022, 12:54 PM

Change 852282 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Make the code size limit for highlighting configurable

https://gerrit.wikimedia.org/r/852282

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2022, 1:30 PM
TheDJ closed this task as Resolved.Nov 28 2022, 9:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL