Page MenuHomePhabricator

Create API module for image recommendation rejections
Closed, ResolvedPublic

Description

We currently use the VisualEditor Edit API for image rejections. That's mostly out of convenience, because we have all the relevant wiring to process the user feedback when using the VisualEditor Edit API. But it would be conceptually clearer if we had a separate API module (e.g. action=growthrejectimagerecommendation). That API module would need to modify the incoming data and then call the AddImageSubmissionHandler.

Acceptance Criteria

  1. Should be able to use action=growthrejectimagerecommendation to reject an image suggestion
  2. Do not use VisualEditor Edit API for image rejection events
Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

T320739#8366082

Related Objects

StatusSubtypeAssignedTask
Resolved sdkim
Resolvedsbassett
OpenNone
ResolvedNone
ResolvedNone
OpenNone
Resolved Urbanecm_WMF
OpenNone
OpenNone
Resolved Urbanecm_WMF
OpenNone
OpenNone
ResolvedCyndymediawiksim
Resolved Urbanecm_WMF
Resolved Urbanecm_WMF
Resolvedkostajh
ResolvedJTannerWMF
Resolvedkostajh
ResolvedNone
ResolvedNone
ResolvedTgr

Event Timeline

I'd probably make this into a generic "submit feedback" API. It will only invoke the submit handler anyway, which already knows how to handle acceptance so it is easy to expose that through the API, and it might be useful for clients which use the non-visual edit API.

Change 880813 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Document plugin parameters of visualeditoredit API

https://gerrit.wikimedia.org/r/880813

Change 880813 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Document plugin parameters of visualeditoredit API

https://gerrit.wikimedia.org/r/880813

I wonder if we should repurpose the growthinvalidateimagerecommendation API for this, or just have two separate APIs. Conceptually invalidating and registering feedback (I don't think it makes much sense to exclude acceptance) are quite difference, but in practice we handle them pretty much the same way.

Change 881801 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Add Image: Create API module for submitting feedback

https://gerrit.wikimedia.org/r/881801

Change 881801 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: Create API module for submitting feedback

https://gerrit.wikimedia.org/r/881801

@KStoller-WMF / @Tgr: Hi, the Due Date set for this open task passed a while ago.
Could you please either update or reset the Due Date (by clicking Edit Task), or set the status of this task to resolved in case this task is done? Thanks!

@Tgr - Extension:GrowthExperiments/Technical documentation/Structured tasks/Add a section image page is not updated. Should it be done in the scope of this task or separately?

I can do that as part of T335715: Section-Level Images: Release checklist

Thx, @kostajh! Then, I'm closing this task as Resolved.