Page MenuHomePhabricator

OOUI PHP demos page is broken (again)
Open, Needs TriagePublic

Description

November 2022 edition of T297035:

https://doc.wikimedia.org/oojs-ui/master/demos/demos.php

Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 7.4.3".

Last time, T247653 fixed it when the requirement was PHP >= 7.2.9. The minimum version was bumped, and... here we go again.

Related: https://integration.wikimedia.org/ci/job/mw-tools-phan-demos-publish/266/console (postmerge for phan-taint-check-plugin) also failed to update the demo on doc.wikimedia.org because it requires PHP 7.4, and there it confirms that 7.3.31 is installed.

Event Timeline

Esanders renamed this task from OOUI PHP demos page is broken again to OOUI PHP demos page is broken (again).Dec 8 2022, 3:42 PM
Esanders added a project: Regression.

doc.wikimedia.org is hosted on doc1002.eqiad.wmnet which has Buster. It gets PHP from Debian and thus runs PHP 7.3.

We might be able to upgrade it to PHP 7.4 by using the same package used by MediaWiki php7.4 from buster-wikimedia/component/php74.

A non exhaustive list of things to check for compatibility

And anything else that might be running PHP scripts.

@hashar Do we have enabled and access to some kind of error_log for the doc1002 php-fpm instance where we might find about PHP Deprecated warnings etc? That might help increase confidence that nothing will break and possibly identify additional things that use PHP.

To my knowledge, though, your list is complete. When I last tried to make a complete list, I saved it at https://wikitech.wikimedia.org/wiki/Doc.wikimedia.org and that seems to match.

@hashar Do we have enabled and access to some kind of error_log for the doc1002 php-fpm instance where we might find about PHP Deprecated warnings etc? That might help increase confidence that nothing will break and possibly identify additional things that use PHP.

I have absolutely no idea whether they are captured anywhere. At least I have never actively looked at the error logs on the hosts themselves and I don't think I ever encountered doc1002 host via our ELK stack. A search there yields no result for doc1002 so I guess the logging pipeline is not setup.

For PHP error_log, we use the stock config files from Debian:

hashar@doc1002:/etc/php/7.3/fpm$ grep -PR ^error_
php-fpm.conf:error_log = /var/log/php7.3-fpm.log
php.ini:error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT

To my knowledge, though, your list is complete. When I last tried to make a complete list, I saved it at https://wikitech.wikimedia.org/wiki/Doc.wikimedia.org and that seems to match.

That is so helpful, thank you for that.

Is there any update on when this is going to be fixed? Not having this documentation severly hinders extension development for those not familiar with OOUI and the documentation on mw.org isn't really exhaustive.

@hashar Do we have enabled and access to some kind of error_log for the doc1002 php-fpm instance where we might find about PHP Deprecated warnings etc? That might help increase confidence that nothing will break and possibly identify additional things that use PHP.

There is a task to drop the logs to logstash indeed: T325245

Is there any update on when this is going to be fixed? Not having this documentation severly hinders extension development for those not familiar with OOUI and the documentation on mw.org isn't really exhaustive.

The root cause is the PHP version comes from the hosts Debian system and upgrading the OS tends to be a bit painful (we got to create a new VM, provision it with a new OS which often requires adjustments to the provisioning manifest, we gotta move data around ...). Those are not necessarily hard, but they come up on top of a long list of things we have to do, thus the progress is rather slow.

Change 901149 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[oojs/ui@master] Revert "[BREAKING CHANGE] Raise claimed PHP need from 7.2+ to 7.4+"

https://gerrit.wikimedia.org/r/901149

Change 901612 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/puppet@production] doc: upgrade php from 7.3 to 7.4

https://gerrit.wikimedia.org/r/901612

doc.wikimedia.org is hosted on doc1002.eqiad.wmnet which has Buster. It gets PHP from Debian and thus runs PHP 7.3.

We might be able to upgrade it to PHP 7.4 by using the same package used by MediaWiki php7.4 from buster-wikimedia/component/php74.
...

That is https://gerrit.wikimedia.org/r/c/operations/puppet/+/901612

There would then be no need to upgrade the hosts to Debian Bullseye, at least not immediately ;)