Page MenuHomePhabricator

Fix tile routes that server non png output on mapnik-3.1
Closed, ResolvedPublic

Description

Currently /osm-intl/17/68236/47794.png serves the requested tile as png. There are other routes that can be reached by changing the (file-)format in the request. These should obviously return a different output. This currently seem to be broken.

Event Timeline

+1 this should be fixed either way, but I think it's also worth comparing against the mapnik-3.0 branch (master) when run locally. If local rendering is always broken, then we can decouple from the upgrade work, in that case it would probably be due to an oversight in the kartodock Dockerfile.

+1 this should be fixed either way, but I think it's also worth comparing against the mapnik-3.0 branch (master) when run locally. If local rendering is always broken, then we can decouple from the upgrade work, in that case it would probably be due to an oversight in the kartodock Dockerfile.

I could confirm that it's not an issue on kartodock and the current master. So it's a new issue in the mapnik-3.1 branch.

Ok seems it has to do with the custom changes in the tilelive-vector lib. e.g. https://github.com/kartotherian/tilelive-vector/commit/a7bfd29a?w=1. I have a WIP that's a forked upstream master and applies the changes on top of it. Try to get that somewhere out there tomorrow.

Change 854518 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/services/kartotherian@mapnik-3.1] [WIP] Fix routes using tilelive vector

https://gerrit.wikimedia.org/r/854518

Change 854518 merged by jenkins-bot:

[mediawiki/services/kartotherian@mapnik-3.1] Fix routes using tilelive vector and abaculus

https://gerrit.wikimedia.org/r/854518