Ensure Mention Tool is in outermost position
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Nov 4 2022, 11:15 PM

Description

T249072 introduced the special characters tool to the Reply and New Topic Tools (desktop).

In doing so, the discussiontools-replywidget-mention-tool-title button no longer appears in the outermost position within the Reply and New Topic Tools' toolbars.

This task involves making it so the the discussiontools-replywidget-mention-tool-title button continues to appear in the outermost position within the Reply and New Topic Tools' toolbars.

Thank you to @Xaosflux for spotting this issue in T249072#8369313.

Behavior

Interface	Current	😊 Desired
Reply Tool (desktop)		`discussiontools-replywidget-mention-tool-title` button appears in the outermost position
New Topic Tool (desktop)		`discussiontools-replywidget-mention-tool-title` button appears in the outermost position

Done

Desired behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	Move username completion tool after special character tool in toolbar	mediawiki/extensions/DiscussionTools	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned In: T249072: Add support in toolbar for special characters within DiscussionTools
Mentioned Here: T249072: Add support in toolbar for special characters within DiscussionTools

Event Timeline

• ppelberg created this task.Nov 4 2022, 11:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2022, 11:15 PM

• ppelberg mentioned this in T249072: Add support in toolbar for special characters within DiscussionTools.Nov 4 2022, 11:15 PM

• ppelberg attached a referenced file: F35705695: image.png. (Show Details)

Change 853998 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Move username completion tool after special character tool in toolbar

https://gerrit.wikimedia.org/r/853998

gerritbot added a project: Patch-For-Review.Nov 7 2022, 1:01 PM

Esanders claimed this task.Nov 7 2022, 1:01 PM

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 853998 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Move username completion tool after special character tool in toolbar

https://gerrit.wikimedia.org/r/853998

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 8 2022, 3:22 AM

matmarex added a project: Editing QA.

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2022, 3:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 8 2022, 4:00 AM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 10 2022, 4:19 AM

Ryasmeen edited projects, added Verified; removed Editing QA.Nov 10 2022, 4:23 AM

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Nov 17 2022, 4:13 PM

• ppelberg closed this task as Resolved.Nov 19 2022, 1:19 AM

Xaosflux awarded a token.Nov 19 2022, 1:42 AM

	F35707405: Screen Shot 2022-11-04 at 4.13.49 PM.png
	Nov 4 2022, 11:15 PM

Ensure Mention Tool is in outermost positionClosed, ResolvedPublicActions