We currently always include two versions of various buttons in the page HTML: one for visual enhancements enabled, and one for visual enhancements disabled. This is wasteful and probably affects page load speed negatively.
However, we need it to support the "Read as wiki page" button that can toggle visual enhancements off without reloading the page.
Once we remove that feature (T280417), we can change this, and only include one version, depending on user preferences.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Only include one set of DiscussionTools buttons in the page HTML | mediawiki/extensions/DiscussionTools | master | +29 K -4 K |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T294592 [EPIC] Ensure Talk Pages Project "Phase 1" work is easy to maintain, build upon, and learn from | |||
| Open | matmarex | T322457 Only include one set of DiscussionTools buttons in the page HTML | |||
| Open | matmarex | T280417 Converge on a single mobile talk page view | |||
| Resolved | matmarex | T310217 Evaluate usage of the "Read as as wiki page" mobile talk page view | |||
| Open | None | T325573 Introduce a setting to decide default collapse/expanded state of mobile talk page sections |
Change 1004799 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Only include one set of DiscussionTools buttons in the page HTML
Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/659039841c/w
@Jack_who_built_the_house FYI, in case Convenient Discussions depends on the current markup. You can try the new one in the demo above.
Thanks for the heads up! I'll keep an eye on this. It seems okay on the patchdemo, but if anything funky happens I'll know where to look.
@matmarex Thanks for the notice. If that markup was already present with "Show discussion activity" enabled, then I think I'm safe. (But had to hastily figure out why subscriptions broke yesterday.)
Change 1004799 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Only include one set of DiscussionTools buttons in the page HTML
(It's live on the beta cluster now, if you want to double-check: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page)
Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted: