Page MenuHomePhabricator
Create Task
Maniphest T322542

🔷 Remove all instances of removed 1.22 k8s APIs
Closed, ResolvedPublic
Actions

Description

We can find references to our deprecated APIs in at least two places

  • In the k8s yaml that we apply using helmfile and helm These can be found by searching through the output of helmfile -q -e <production/staging> template (e.g. | grep -B 10 extensions/v1beta1)
  • - our internal charts
    • - wikibase-ingress
  • stable charts
    • - nginx-ingress-controller
  • kubernetes-client

Related Objects
Search...

Event Timeline

Tarrow created this task.Nov 7 2022, 1:25 PM
Tarrow removed Tarrow as the assignee of this task.
Tarrow updated the task description. (Show Details)Nov 7 2022, 1:43 PM
Tarrow added a subtask: T311505: 🔵 Resolve Kubernetes client bump from dependabot PR.
Tarrow updated the task description. (Show Details)
Tarrow updated the task description. (Show Details)Nov 7 2022, 1:50 PM
Tarrow added a comment.Nov 7 2022, 2:31 PM

On further inspection it appears that the errant nginx-ingress-controller wasn't actually from the bitnami charts repository... it's actually from the official stable helm one.

Tarrow updated the task description. (Show Details)Nov 7 2022, 2:32 PM
Tarrow renamed this task from Remove all instances of removed 1.22 k8s APIs to 🔵 Remove all instances of removed 1.22 k8s APIs.Nov 8 2022, 3:26 PM
Tarrow renamed this task from 🔵 Remove all instances of removed 1.22 k8s APIs to 🔷 Remove all instances of removed 1.22 k8s APIs.Nov 8 2022, 3:28 PM
dena moved this task from Wikibase.cloud (WB Cloud Sprint 8) to Wikibase.cloud (WB Cloud Sprint 9) on the Wikibase Cloud board.Nov 9 2022, 1:14 PM
dena edited projects, added Wikibase Cloud (Wikibase.cloud (WB Cloud Sprint 9)); removed Wikibase Cloud (Wikibase.cloud (WB Cloud Sprint 8)).
dena updated the task description. (Show Details)Nov 21 2022, 2:48 PM
dena updated the task description. (Show Details)Nov 22 2022, 12:43 PM
dena moved this task from Sprint Backlog to In Verification on the Wikibase Cloud (Wikibase.cloud (WB Cloud Sprint 9)) board.Nov 22 2022, 6:04 PM
Evelien_WMDE moved this task from Wikibase.cloud (WB Cloud Sprint 9) to WB Cloud Sprint 10 on the Wikibase Cloud board.Nov 23 2022, 1:10 PM
Evelien_WMDE edited projects, added Wikibase Cloud (WB Cloud Sprint 10); removed Wikibase Cloud (Wikibase.cloud (WB Cloud Sprint 9)).
Evelien_WMDE moved this task from Sprint Backlog to Waiting for Deploy to Production on the Wikibase Cloud (WB Cloud Sprint 10) board.
Evelien_WMDE moved this task from Waiting for Deploy to Production to In Verification on the Wikibase Cloud (WB Cloud Sprint 10) board.
Evelien_WMDE closed subtask T322552: 🔵 Update nginx-ingress to ingress-nginx chart v4.2.5 as Resolved.Nov 23 2022, 1:20 PM
Evelien_WMDE closed subtask T322543: 🔵 Remove beta ingress API from wikibase-ingress chart as Resolved.
Evelien_WMDE closed subtask T311505: 🔵 Resolve Kubernetes client bump from dependabot PR as Resolved.
dena claimed this task.Nov 23 2022, 1:25 PM
dena added a comment.Nov 23 2022, 4:24 PM

We may have missed a chart that still uses the old beta ingress api, since I get the following error now locally if I want to create a cluster from scratch:

Error: Failed to render chart: exit status 1: Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Ingress" in version "extensions/v1beta1"

Probably one of the 3rd party charts, maybe a local-only one, since I can't find any file in our repos containing v1beta1.

dena added a comment.Nov 23 2022, 6:14 PM

My assumption was correct, the problematic chart was the local-only used chart for adminer. This PR updates the chart version which fixes it https://github.com/wmde/wbaas-deploy/pull/601

Otherwise this looks good to me. We should check the Google Cloud UI again though, it should be happy too after 30 days.

dena removed dena as the assignee of this task.Nov 23 2022, 6:14 PM
dena moved this task from In Verification to Done on the Wikibase Cloud (WB Cloud Sprint 10) board.
Evelien_WMDE closed this task as Resolved.Dec 7 2022, 10:36 AM
Evelien_WMDE claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits