Page MenuHomePhabricator
Create Task
Maniphest T322553

Remove use of AbstractBlock::getPermissionsError from CheckBlocksSecondaryAuthenticationProvider
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This use case was introduced by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/824142, because no alternative existed.

Since T317308: GlobalBlocking should specify block error message key, the block message should be displayed properly by the block error formatter.

This task is blocking T317204: Remove getPermissionsError from GlobalBlock.

Details

SubjectRepoBranchLines +/-
Remove deprecated method call from CheckBlocksSecondaryAuthenticationProvidermediawiki/coremaster+11 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Nov 7 2022, 3:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2022, 3:33 PM
Tchanders set the point value for this task to 1.Nov 7 2022, 3:33 PM
gerritbot added a comment.Nov 7 2022, 3:55 PM

Change 854033 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Remove deprecated method call from CheckBlocksSecondaryAuthenticationProvider

https://gerrit.wikimedia.org/r/854033

gerritbot added a project: Patch-For-Review.Nov 7 2022, 3:55 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 19: The Deerstalker) board.Nov 7 2022, 3:57 PM
Tchanders added a parent task: T317204: Remove getPermissionsError from GlobalBlock.
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 19: The Sanbenito); removed Anti-Harassment (AHaT Sprint 19: The Deerstalker).Nov 8 2022, 5:23 AM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.
Tchanders added a project: Growth-Team.Nov 10 2022, 1:10 PM
Tchanders moved this task from Code Review 🔍 to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.Nov 15 2022, 2:13 PM
gerritbot added a comment.Nov 16 2022, 7:58 AM

Change 854033 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated method call from CheckBlocksSecondaryAuthenticationProvider

https://gerrit.wikimedia.org/r/854033

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 16 2022, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 16 2022, 8:30 AM
Tchanders moved this task from Blocked/Stalled 🚧 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.Nov 18 2022, 7:13 AM
Tgr moved this task from Inbox to Triaged on the Growth-Team board.Nov 20 2022, 8:23 AM
Niharika closed this task as Resolved.Dec 8 2022, 1:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL