Page MenuHomePhabricator

Display deleted/suppressed participants on Special:EventDetails
Closed, ResolvedPublic3 Estimated Story Points

Description

If an event participant's account is blocked+suppressed, they won't appear on Special:EventDetails. This makes the "X participants" label inconsistent with what is actually shown, and can result in equally confusing behaviour when selecting/searching/removing participants. As an example, see item (2.) in the description of T320649. Also, suppressed participants cannot be removed unless you choose to remove all participants. These inconsistencies also makes it harder to maintain the relevant code.

As such, I propose that deleted/suppressed participants be shown on EventDetails. Visually, entries for deleted users would be identical to those for visible users, but there would be some text saying "username suppressed" (or similar, consistently with what we do for organizers) instead of the username. It goes without saying that no suppressed users should be shown when searching by username.

Acceptance criteria

Assuming that an event has participants whose accounts were either deleted or suppressed, if I am on Special:EventDetails for that event, then:

  • Deleted participants are listed, and there's grey text saying "deleted user" instead of the user page link
  • Suppressed participants are listed, and there's grey text saying "username suppressed" instead of the user page link
  • If I scroll down until all participants are loaded, the number of participants shown in the interface should match the number at the top of the panel ("X participants")
  • The label which reads "X selected" will also have the correct number of participants; that is, problem (2.) described in T320649 should be fixed
  • The documentation of the "List the participants of an event" endpoint is updated and it includes the new properties added to the response.

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptNov 7 2022, 6:57 PM
ldelench_wmf set the point value for this task to 3.Nov 7 2022, 9:02 PM

Change 854128 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Show deleted participants on Special:EventDetails

https://gerrit.wikimedia.org/r/854128

Change 854128 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Show deleted participants on Special:EventDetails

https://gerrit.wikimedia.org/r/854128

โœ… Deleted participants are listed, and there's grey text saying "deleted user" instead of the user page link

โœ… Suppressed participants are listed, and there's grey text saying "username suppressed" instead of the user page link

โœ… If I scroll down until all participants are loaded, the number of participants shown in the interface should match the number at the top of the panel ("X participants")

โœ… The label which reads "X selected" will also have the correct number of participants; that is, problem (2.) described in T320649 should be fixed

โœ… The documentation of the "List the participants of an event" endpoint is updated and it includes the new properties added to the response.


Public registration

Created three users, Suppresseduser, DeletedUser, BlockedUser

Screen Shot 2022-11-17 at 2.34.10 PM.png (1ร—1 px, 167 KB)

Suppressing the user Suppresseduser through Special:CentralAuth successfully and choosing the option Account is hidden completely replaces the user name in Special:EventDetails with username suppressed

Screen Shot 2022-11-17 at 3.21.56 PM.png (1ร—1 px, 153 KB)

Deleting the user Deleteduser through Special:CentralAuth successfully replaces the user name in Special:EventDetails with deleted user

Screen Shot 2022-11-17 at 2.47.32 PM.png (1ร—1 px, 144 KB)


Private registration

Created two privately registered users and then after they registered for the event, deleted one and globally suppressed the other through Special:CentralAuth

privately registered and then deleted user. and privately registered and then globally suppressed users function the same as their privately registered counterparts, except they display with the padlock beside of them when viewed by the organizer.

Screen Shot 2022-11-17 at 3.48.10 PM.png (1ร—1 px, 172 KB)


One question, @Daimona - Blocking user Blockeduser through Special:Block however does not currently prevent the user from displaying in the participant list. This is likely as expected since this is a local block?

Screen Shot 2022-11-17 at 2.44.18 PM.png (1ร—1 px, 142 KB)

One question, @Daimona - Blocking user Blockeduser through Special:Block however does not currently prevent the user from displaying in the participant list. This is likely as expected since this is a local block?

Yup, if the wiki has CentralAuth, local blocks are ignored, so that would be expected.

ifried subscribed.

This looks good, as detailed by the tests conducted by Vaughn, so I'm marking this as Done.