Page MenuHomePhabricator

Update copyright notices throughout AQS 2.0
Closed, ResolvedPublic

Description

Numerous files throughout the AQS 2.0 services claim to be "Copyright 2021 Nikki Nikkhoui <nnikkhoui@wikimedia.org> and Wikimedia Foundation", because we never updated the boilerplate from the Go service scaffolding.

We should change the copyright date to 2022, and remove mention of Nikki. As much as we may still love her, she's no longer a staff member and we shouldn't claim copyright on her behalf for new services that she wasn't involved with.

We should also add copyright notices to files in aqsassist, which are currently lacking them.

  • pageviews
  • unique devices
  • mediarequests
  • editors
  • wikistats2
  • aqsassist

Note: the above list may change if we choose to change service names, per discussion in T288301: AQS 2.0:Wikistats 2 service. The same codebases will need updated, but they may be known by different names.

Event Timeline

I merged https://gitlab.wikimedia.org/repos/generated-data-platform/aqs/mediarequests/-/merge_requests/3, which updated the copyright notice for main.go in mediarequests. However, config.go and healthz.go also have copyright notices that need updated.

Same thing for unique devices, I merged https://gitlab.wikimedia.org/repos/generated-data-platform/aqs/unique-devices/-/merge_requests/10, which updated the copyright notice for main.go in unique devices. However, config.go and healthz.go also have copyright notices that need updated.

I realises aqsassist does not have the copyright issue

@BPirkle could you kindly review these. thank you

Change 862249 had a related patch set uploaded (by Atieno; author: WQuarshie):

[generated-data-platform/aqs/device_analytics@main] T322590: error handling and copyright change

https://gerrit.wikimedia.org/r/862249

Change 862250 had a related patch set uploaded (by Atieno; author: WQuarshie):

[generated-data-platform/aqs/device_analytics@main] T322590: Copyright

https://gerrit.wikimedia.org/r/862250

Change 862249 merged by BPirkle:

[generated-data-platform/aqs/device_analytics@main] T322590: error handling and copyright change

https://gerrit.wikimedia.org/r/862249

Change 862250 merged by BPirkle:

[generated-data-platform/aqs/device_analytics@main] T322590: Copyright

https://gerrit.wikimedia.org/r/862250