Page MenuHomePhabricator

Allow to disconnect a remote account
Open, Needs TriagePublic

Description

Context: after T283908, already-existing users can auto-link their remote account without haggling with a server administrator. This is really good.

Current situation: after an user connects a remote account, this is what they see from the preferences:

WSOAuth - preferences - remote account highlighted with green peppers.png (485×986 px, 101 KB)

Current missing feature: the user cannot de-link that remote account.

Use cases:

  • fix an accidental login from another remote account
  • delink an untrusted remote (e.g. Elon Musk bought your platform) - so you rely on local username-password or other remotes if supported
  • troubleshoot the platform - showing other people that it works (or not)
  • replay the login - for example because you really like T283908

Proposed solution: add a "Disconnect" button, allowing people to disconnect from the remote account.

Things to discuss: allowing to "Disconnect" a remote account may not be liked by everyone since this extension has many uses, sometime relying on only-remote login. So I propose to implement this feature, disable for everyone as default. Kind of:

$wgOAuthAllowDisconnect = false

Details

Event Timeline

Hi @valerio.bozzolan! I have implemented this. Please take a look to see if it meets your requirements: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WSOAuth/+/912282.

Really a great news!

I hope it was not so complicated, but looking at your change I can just thank you for your efforts.

I can test it this Thursday in a serious way.

Just for my early curiosity, do you have a screenshot?

Unfortunately with WMCH I was stuck with the compatibility matrix of WSOAuth and Pluggable-thing. Also with the lack of official time allocable on that.

I hope we can test these things faster for you in the future to allow a more creative area and faster review, since this is a great extension.

Aklapper added a subscriber: Xxmarijnw.

The email address of @Xxmarijnw set in Wikimedia Phabricator bounces, thus unassigning.

The user proposed a patch:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WSOAuth/+/912282

All the glory so goes to @Xxmarijnw and somebody with knowledge of that codebase should review (I have not). Also I do not understand which combination of WSOAuth and Pluggable-thing we should have to test since I'm stupid, but this assign field is correct.

This helped me realize the e-mail I had assigned in Phabricator is very old, and no longer works :)

Is this going to be available soon? I am planning to submit the app for my wiki to Facebook soon and would like to allow users to disconnect their FB account.

Change #912282 had a related patch set uploaded (by Aklapper; author: Xxmarijnw):

[mediawiki/extensions/WSOAuth@master] Allow users to disconnect a remote

https://gerrit.wikimedia.org/r/912282

@Oldiesmann: Whenever someone volunteers to rework the available patch and once that patch got accepted