Page MenuHomePhabricator

🌯️ Create Deserializers to read adjusted statement data structure
Closed, ResolvedPublic

Description

Create the following Deserializers without plugging them in, yet:

  • PropertyValuePairDeserializer
    • delegates to value deserializer if value.type is value
    • creates the snak object
  • value content deserializer (to be used for defined values, i.e. not novalue or somevalue)
    • gets the serialization including the property id
    • looks up the property's data type based on the id
    • maps the data type to the value type to figure out how to deserialize the value (mapping via WikibaseRepo.DataTypeDefinitions or something similar)
  • top level statement deserializer
    • creates statement from id and rank
    • delegates to inner deserializers for the other fields
  • ReferenceListDeserializer
    • has a ReferenceDeserializer
  • qualifiers deserializer (probably just iterates over a list and calls PropertyValuePairDeserializer)

Event Timeline

Silvan_WMDE renamed this task from Create Deserializers to read adjusted statement data structure to 🌯️ Create Deserializers to read adjusted statement data structure.Nov 8 2022, 4:19 PM
Silvan_WMDE created this task.

Change 855989 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add PropertyValuePairDeserializer

https://gerrit.wikimedia.org/r/855989

Change 856553 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add StatementDeserializer

https://gerrit.wikimedia.org/r/856553

Change 856565 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add ReferenceDeserializer

https://gerrit.wikimedia.org/r/856565

Change 855989 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add PropertyValuePairDeserializer

https://gerrit.wikimedia.org/r/855989

Change 856553 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add StatementDeserializer

https://gerrit.wikimedia.org/r/856553

Change 856565 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add ReferenceDeserializer

https://gerrit.wikimedia.org/r/856565