Page MenuHomePhabricator
Create Task
Maniphest T322655

🌯️ Cleanup after statement data structure change
Closed, ResolvedPublic
Actions

Description

  • remove the now unused schema parts from the OAS
  • remove any unused classes

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Simplify response definitions in OASmediawiki/extensions/Wikibasemaster+19 -20
REST: Rename "new" definitions in OASmediawiki/extensions/Wikibasemaster+14 -14
REST: Remove unused definitions from OASmediawiki/extensions/Wikibasemaster+0 -159
REST: Remove unused REST API Domain Deserializermediawiki/extensions/Wikibasemaster+0 -62
REST: Remove legacy statement format response specsmediawiki/extensions/Wikibasemaster+16 -68
REST: Rename RestSerializerFactory -> SerializerFactorymediawiki/extensions/Wikibasemaster+17 -17
REST: Remove unused Serializers and legacy Factorymediawiki/extensions/Wikibasemaster+0 -382
REST: Remove legacy format statement response specsmediawiki/extensions/Wikibasemaster+16 -68
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Nov 8 2022, 4:31 PM
Jakob_WMDE claimed this task.Nov 16 2022, 1:36 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 17) board.
gerritbot added a comment.Nov 16 2022, 3:20 PM

Change 857664 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove unused legacy SerializerFactory

https://gerrit.wikimedia.org/r/857664

gerritbot added a project: Patch-For-Review.Nov 16 2022, 3:20 PM
gerritbot added a comment.Nov 16 2022, 3:25 PM

Change 857666 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Rename RestSerializerFactory -> SerializerFactory

https://gerrit.wikimedia.org/r/857666

gerritbot added a comment.Nov 17 2022, 1:02 PM

Change 858209 abandoned by Jakob:

[mediawiki/extensions/Wikibase@master] REST: Remove legacy format statement response specs

Reason:

https://gerrit.wikimedia.org/r/858209

gerritbot added a comment.Nov 17 2022, 2:20 PM

Change 857664 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused Serializers and legacy Factory

https://gerrit.wikimedia.org/r/857664

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 17 2022, 3:00 PM
gerritbot added a comment.Nov 17 2022, 3:17 PM

Change 857666 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename RestSerializerFactory -> SerializerFactory

https://gerrit.wikimedia.org/r/857666

Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Nov 18 2022, 11:50 AM
Jakob_WMDE moved this task from Doing to To Do on the Wikibase Product Platform (v1) (Sprint 17) board.
Jakob_WMDE subscribed.

Ok, I think everything that can be done at this point is either merged or waiting for review. Additional clean up work will be unlocked once T322653 is done.

The goal should be to:

  • remove all remaining classes in the Wikibase\Repo\RestApi\Domain\Serialization namespace
  • remove all remaining OpenAPI definitions using the old format (*Request definitions, schema parts etc)
  • remove the "New" prefix from the definition keys now that it's updated everywhere
gerritbot added a comment.Nov 21 2022, 12:07 PM

Change 858211 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove legacy statement format response specs

https://gerrit.wikimedia.org/r/858211

Ollie.Shotton_WMDE claimed this task.Nov 21 2022, 4:23 PM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 17) board.
gerritbot added a comment.Nov 21 2022, 5:49 PM

Change 859115 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove unused REST API Domain Deserializer

https://gerrit.wikimedia.org/r/859115

gerritbot added a comment.Nov 21 2022, 5:49 PM

Change 859116 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove unused definitions from OAS

https://gerrit.wikimedia.org/r/859116

gerritbot added a comment.Nov 21 2022, 5:49 PM

Change 859117 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Rename "new" definitions in OAS

https://gerrit.wikimedia.org/r/859117

gerritbot added a comment.Nov 21 2022, 5:49 PM

Change 859118 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Simplify response definitions in OAS

https://gerrit.wikimedia.org/r/859118

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 17) board.Nov 22 2022, 10:12 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 18); removed Wikibase Product Platform (v1) (Sprint 17).Nov 22 2022, 10:32 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 18) board.
gerritbot added a comment.Nov 23 2022, 2:22 PM

Change 859115 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused REST API Domain Deserializer

https://gerrit.wikimedia.org/r/859115

gerritbot added a comment.Nov 23 2022, 3:18 PM

Change 859116 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused definitions from OAS

https://gerrit.wikimedia.org/r/859116

gerritbot added a comment.Nov 23 2022, 3:20 PM

Change 859117 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename "new" definitions in OAS

https://gerrit.wikimedia.org/r/859117

gerritbot added a comment.Nov 23 2022, 3:38 PM

Change 859118 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Simplify response definitions in OAS

https://gerrit.wikimedia.org/r/859118

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 18) board.Nov 24 2022, 10:04 AM
WMDE-leszek closed this task as Resolved.Jan 5 2023, 1:44 PM
Michael mentioned this in T353626: Remove OPTION_OBJECTS_FOR_MAPS flag from SerializerFactory (dead code).Dec 18 2023, 11:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits