Page MenuHomePhabricator

🌯️ Cleanup after statement data structure change
Closed, ResolvedPublic

Description

  • remove the now unused schema parts from the OAS
  • remove any unused classes

Event Timeline

Change 857664 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove unused legacy SerializerFactory

https://gerrit.wikimedia.org/r/857664

Change 857666 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Rename RestSerializerFactory -> SerializerFactory

https://gerrit.wikimedia.org/r/857666

Change 858209 abandoned by Jakob:

[mediawiki/extensions/Wikibase@master] REST: Remove legacy format statement response specs

Reason:

https://gerrit.wikimedia.org/r/858209

Change 857664 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused Serializers and legacy Factory

https://gerrit.wikimedia.org/r/857664

Change 857666 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename RestSerializerFactory -> SerializerFactory

https://gerrit.wikimedia.org/r/857666

Jakob_WMDE subscribed.

Ok, I think everything that can be done at this point is either merged or waiting for review. Additional clean up work will be unlocked once T322653 is done.

The goal should be to:

  • remove all remaining classes in the Wikibase\Repo\RestApi\Domain\Serialization namespace
  • remove all remaining OpenAPI definitions using the old format (*Request definitions, schema parts etc)
  • remove the "New" prefix from the definition keys now that it's updated everywhere

Change 858211 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove legacy statement format response specs

https://gerrit.wikimedia.org/r/858211

Change 859115 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove unused REST API Domain Deserializer

https://gerrit.wikimedia.org/r/859115

Change 859116 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove unused definitions from OAS

https://gerrit.wikimedia.org/r/859116

Change 859117 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Rename "new" definitions in OAS

https://gerrit.wikimedia.org/r/859117

Change 859118 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Simplify response definitions in OAS

https://gerrit.wikimedia.org/r/859118

Change 859115 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused REST API Domain Deserializer

https://gerrit.wikimedia.org/r/859115

Change 859116 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused definitions from OAS

https://gerrit.wikimedia.org/r/859116

Change 859117 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename "new" definitions in OAS

https://gerrit.wikimedia.org/r/859117

Change 859118 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Simplify response definitions in OAS

https://gerrit.wikimedia.org/r/859118