Show ZID instead of nothing for implementations and testers without a label
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DVrandecic
	Nov 8 2022, 8:57 PM

Description

The second implementation here:

https://wikifunctions.beta.wmflabs.org/wiki/Z10118

(click on Details)

shows as an empty line in the table, which makes it also unclickable. We should show the ZID there.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Show ZID for testers with no labels in the Tester Table.	mediawiki/extensions/WikiLambda	master	+24 -0
	On Implementations + Tester tables, when no label show ZID.	mediawiki/extensions/WikiLambda	master	+40 -2

Customize query in gerrit

Event Timeline

DVrandecic created this task.Nov 8 2022, 8:57 PM

Jdforrester-WMF renamed this task from Show ZID instead of nothin for implementations without label to Show ZID instead of nothing for implementations without a label.Nov 15 2022, 7:40 PM

DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 15 2022, 7:40 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

DVrandecic updated the task description. (Show Details)Nov 16 2022, 12:56 AM

gengh moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 16 2022, 7:39 AM

An additional issue with the no label, is how the implementation shows in the testers table. (Displays the class)

Screen Shot 2022-11-16 at 9.46.00 AM.png (612×703 px, 145 KB)

Change 857056 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] On Implementations + Tester tables, when no label show ZID.

https://gerrit.wikimedia.org/r/857056

gerritbot added a project: Patch-For-Review.Nov 16 2022, 3:37 PM

Ddwaal claimed this task.Nov 16 2022, 3:41 PM

Change 857056 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] On Implementations + Tester tables, when no label show ZID.

https://gerrit.wikimedia.org/r/857056

Maintenance_bot removed a project: Patch-For-Review.Nov 17 2022, 9:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 17 2022, 12:00 PM

This is true of testers with no labels too, and should be implemented similarly.

Change 858367 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Show ZID for testers with no labels in the Tester Table.

https://gerrit.wikimedia.org/r/858367

gerritbot added a project: Patch-For-Review.Nov 17 2022, 3:28 PM

Ddwaal renamed this task from Show ZID instead of nothing for implementations without a label to Show ZID instead of nothing for implementations and testers without a label.Nov 18 2022, 4:20 PM

Change 858367 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Show ZID for testers with no labels in the Tester Table.

https://gerrit.wikimedia.org/r/858367

Ddwaal moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 21 2022, 2:53 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2022, 3:30 PM

Jdforrester-WMF closed this task as Resolved.Nov 22 2022, 3:06 PM

	F35786297: Screen Shot 2022-11-16 at 9.46.00 AM.png
	Nov 16 2022, 2:47 PM

Show ZID instead of nothing for implementations and testers without a labelClosed, ResolvedPublicActions

Description

Details

Event Timeline

Show ZID instead of nothing for implementations and testers without a label
Closed, ResolvedPublic
Actions