Page MenuHomePhabricator

Phonos: Fix error popups in Legacy Vector
Closed, ResolvedPublic3 Estimated Story Points

Description

The error pop ups are not showing over content in Legacy Vector.

error_popup_zindex.png (353Γ—457 px, 53 KB)

Event Timeline

Change 854648 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/skins/Vector@master] Set z-index for vector-body higher than mw-panel

https://gerrit.wikimedia.org/r/854648

Possibly a fix for this is to put the popup in its own overlay. That's how other popup/dialog components get around this problem.

@Samwilson, @MusikAnimal did mention the overlay solution but we are trying to see if the z-index can be a possible fix for legacy vector since it's the only case where we noticed this issue.

I tagged @matmarex in the task. Is there anyone else that I can ask?

Change 856878 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Phonos@master] Switch from a ButtonWidget to a PopupButtonWidget

https://gerrit.wikimedia.org/r/856878

I've experimented a bit with moving the popup into an overlay: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Phonos/+/856878 (Sorry @HMonroy I hope I'm not treading on your code! I just got carried away.) I'm not sure if this patch is any good, but I think it's probably good to shift the popup in some way.

Change 854648 abandoned by HMonroy:

[mediawiki/skins/Vector@master] Set z-index for vector-body higher than mw-panel

Reason:

We are going with an overlay instead https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Phonos/+/856878/

https://gerrit.wikimedia.org/r/854648

@Samwilson thank you for your help with this! I abandoned my patch. Should I assign this task to you so that it reflects that you're working on it.?

@matmarex Thank you for taking a look, we're moving the popup to an overlay.

Change 856878 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Switch from a ButtonWidget to a PopupButtonWidget

https://gerrit.wikimedia.org/r/856878

@HMonroy @Samwilson I validated that Chrome, Safari, FireFox, and Edge have pop-up errors that don't mesh with the left window pane but lay over top of it in the Legacy Vector skin.

In IE11 though, I could not test it since the error pop-up doesn't appear for some reason as seen in the screenshot. Is there a reason why it does not pop up in IE11 or do we not support IE 11 on this any more? If it's not supported, we can move this to Done.

Environment: Beta
OS: Multi
Phonos tested: <phonos ipa="mexiko" text="foo" lang="eszzzz" />

IE11 - Error pop-up does not appear

T322702_Phonos_ErrorOverContent_IE11_FAIL.png (647Γ—1 px, 554 KB)

'Chrome'

T322702_Phonos_ErrorOverContent_Chrome.png (569Γ—1 px, 127 KB)

Edge

T322702_Phonos_ErrorOverContent_Edge.png (507Γ—1 px, 545 KB)

FireFox

T322702_Phonos_ErrorOverContent_FireFox.png (595Γ—1 px, 667 KB)

Safari

T322702_Phonos_ErrorOverContent_Safari.png (881Γ—2 px, 227 KB)

dom_walden subscribed.

I am seeing T318958 again, possibly caused by this change.

I will be moving this task to Product sign-off since the issue on this ticket has been validated with IE11 not being supported. T318958 has been reopened in QA to test again.

HMonroy set the point value for this task to 3.Dec 6 2022, 7:42 PM