Page MenuHomePhabricator

Requesting access to analytics-privatedata-users for ryasmeen (superset access with no server access)
Closed, ResolvedPublicRequest

Description

Requestor provided information and prerequisites

This section is to be completed by the individual requesting access.

  • Wikitech username: ryasmeen
  • Email address: ryasmeen@wikimedia.org
  • SSH public key (must be a separate key from Wikimedia cloud SSH access):
  • Requested group membership: analytics-privatedata-users
  • Reason for access: I need to be able to view this dashboard: https://superset.wikimedia.org/superset/dashboard/372/ for the Edit Check project by Editing team.
  • Name of approving party (manager for WMF/WMDE staff): @ppelberg
  • Ensure you have signed the L3 Wikimedia Server Access Responsibilities document: not yet.
  • Please coordinate obtaining a comment of approval on this task from the approving party.

SRE Clinic Duty Confirmation Checklist for Access Requests

This checklist should be used on all access requests to ensure that all steps are covered, including expansion to existing access. Please double check the step has been completed before checking it off.

This section is to be confirmed and completed by a member of the SRE team.

  • - User has signed the L3 Acknowledgement of Wikimedia Server Access Responsibilities Document.
  • - User has a valid NDA on file with WMF legal. (All WMF Staff/Contractor hiring are covered by NDA. Other users can be validated via the NDA tracking sheet)
  • - User has provided the following: wikitech username, email address, and full reasoning for access (including what commands and/or tasks they expect to perform)
  • - User has provided a public SSH key. This ssh key pair should only be used for WMF cluster access, and not shared with any other service (this includes not sharing with WMCS access, no shared keys.)
  • - access request (or expansion) has sign off of WMF sponsor/manager (sponsor for volunteers, manager for wmf staff)
  • - access request (or expansion) has sign off of group approver indicated by the approval field in data.yaml

For additional details regarding access request requirements, please see https://wikitech.wikimedia.org/wiki/Requesting_shell_access

Event Timeline

Change 855492 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] admin: add ryasmeen to analytics-privatedata

https://gerrit.wikimedia.org/r/855492

Request looks good to me, @Ottomata @odimitrijevic I'm seeking approval for the above! Thank you

fgiunchedi triaged this task as Medium priority.Nov 10 2022, 9:24 AM

Change 855492 merged by Filippo Giunchedi:

[operations/puppet@production] admin: add ryasmeen to analytics-privatedata-users

https://gerrit.wikimedia.org/r/855492

fgiunchedi claimed this task.

Thank you @Ottomata ! @Ryasmeen this is complete, access will be live in the next 30min. I'm resolving the task, though feel free to reopen if sth is amiss

@fgiunchedi the above patch is missing the ssh_keys key and that broke the /usr/local/bin/cross-validate-accounts script that is expecting that as a required key.

Change 856484 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] admin: add ssh_keys for ryasmeen

https://gerrit.wikimedia.org/r/856484

Change 856485 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] admin: validate human users have ssh_keys

https://gerrit.wikimedia.org/r/856485

Interesting, thank you for the heads up @Volans . There's an obvious disconnect between CI validation of data.yaml and what cross-validate-accounts expects. Should we make sure all accounts have ssh_keys (even if empty) or should cross-validate-accounts tolerate a missing ssh_keys ? I've gone with the CI route but easy enough to change

I'm ok either way, probably I'd go the CI way too, but check with moritz/john on that to be sure.

Change 856484 merged by Filippo Giunchedi:

[operations/puppet@production] admin: add ssh_keys for ryasmeen

https://gerrit.wikimedia.org/r/856484

Change 856485 merged by Filippo Giunchedi:

[operations/puppet@production] admin: validate human users have ssh_keys

https://gerrit.wikimedia.org/r/856485