Page MenuHomePhabricator

NewImpact module: Empty data screen
Closed, ResolvedPublic

Assigned To
Authored By
kostajh
Nov 10 2022, 11:13 AM
Referenced Files
F35968066: Screen Shot 2023-01-03 at 12.59.16 PM.png
Jan 3 2023, 9:00 PM
F35968064: Screen Shot 2023-01-03 at 12.35.24 PM.png
Jan 3 2023, 9:00 PM
F35816006: image.png
Nov 23 2022, 5:01 PM
F35815588: image.png
Nov 23 2022, 11:49 AM
F35815584: image.png
Nov 23 2022, 11:49 AM
F35815558: image.png
Nov 23 2022, 11:43 AM
F35811061: image.png
Nov 21 2022, 8:34 PM
F35811059: image.png
Nov 21 2022, 8:34 PM

Description

It's possible that requesting impact data will result in "no data" (for all data points) while it is being calculated. We need a simple screen to inform the user that the data is being calculated (or recalculated), and to check back later.

Proposed design
Without "Refresh" CTA Desktop
image.png (1×904 px, 82 KB)
With "Refresh" Desktop
image.png (1×936 px, 77 KB)
Mobile summary (if tapped, opens to Mobile impact without "Refresh CTA")
image.png (220×420 px, 16 KB)
Mobile summary (if tapped, opens to Mobile impact with "Refresh CTA")
image.png (204×406 px, 14 KB)
Without "Refresh" CTA Mobile
image.png (590×352 px, 40 KB)
With "Refresh" Mobile
image.png (794×470 px, 50 KB)

If the person taps on the summary, or navigates to impact module directly on mobile, they will see the mobile version of the error state.

Illustration SVG:

Figma: https://www.figma.com/file/fOa1x7hw6EM9VnaMJv7vib/Positive-reinforcement?node-id=3322%3A112077&t=OfLpTYDR7KXPsp0s-4

Note: All copy is DRAFT - final text will be updated as part of T322890

Acceptance Criteria

  1. Should be able to see a "no data" screen on the impact module, when no cached data for the user exists.
Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

kostajh added a subscriber: RHo.

@RHo would you be able to put together a mock for this, please?

RHo removed RHo as the assignee of this task.Nov 11 2022, 3:33 PM
RHo attached a referenced file: F35754659: image.png. (Show Details)
RHo attached a referenced file: F35754657: image.png. (Show Details)
RHo removed a project: Growth Design.
kostajh changed the task status from Open to In Progress.Nov 14 2022, 1:04 PM
kostajh triaged this task as Medium priority.

Do we need to make any changes to the informational text inside the info popovers for this state?

The thanks received text reads fine:

Wikipedia is created by a community of editors like you. You may be thanked by another contributor for an edit you’ve made, and you can thank others for their edits too.

but for the longest streak maybe we should remove the second paragraph?

This is the highest number of days in a row that you made at least one edit.
Your current longest streak is 3 days which you achieved between Sep 29 2022 — Oct 1 2022.

As a side note, currently we're displaying the unactivated state when a user visits some other user impact page, Special:Impact/{username}. For instance if Alice wants to see LatestEmpty impact data this is what they would see currently:

Screenshot 2022-11-15 at 09.45.14.png (1×1 px, 240 KB)

We could re-use the work from this task to display an empty state when a user visits someone else's screen. I think it would make the experience more consistent.

Change 858347 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: empty data screen

https://gerrit.wikimedia.org/r/858347

I started working on this and realized we probably would want a different design for the overlay summary view. Maybe without scorecards. Otherwise it looks like:

Screenshot 2022-11-17 at 16.40.29.png (2×844 px, 264 KB)

What do you think? @RHo

I started working on this and realized we probably would want a different design for the overlay summary view. Maybe without scorecards. Otherwise it looks like:

Screenshot 2022-11-17 at 16.40.29.png (2×844 px, 264 KB)

What do you think? @RHo

Hi @Sgs - you're right, I forgot about the Mobile summary view. I've updated the figma with designs to show that the summary will display only text in a inline warning message. If the person taps on the summary, or navigates to impact module directly on mobile, they will see the mobile version of the error state.

image.png (1×792 px, 178 KB)

@RHo could we consider rewording the subtext? That version might not work so well with non-Wikipedia wikis... well, maybe it does with {{SITENAME}}. But editing and coming back later won't necessarily resolve the error, and it seems like the wording implies that it would. Maybe something like "Please check back later." ?

@RHo could we consider rewording the subtext? That version might not work so well with non-Wikipedia wikis... well, maybe it does with {{SITENAME}}. But editing and coming back later won't necessarily resolve the error, and it seems like the wording implies that it would. Maybe something like "Please check back later." ?

On a similar note, removing the subtext entirely from the mobile summary might look less jarring, as it is now, that mobile summary looks somewhat unfinished alongisde the other modules? Though perhaps the correct text indentation/alignment would help, I'll comment on the patch about fixing that.

image.png (1×894 px, 167 KB)

@RHo could we consider rewording the subtext? That version might not work so well with non-Wikipedia wikis... well, maybe it does with {{SITENAME}}. But editing and coming back later won't necessarily resolve the error, and it seems like the wording implies that it would. Maybe something like "Please check back later." ?

On a similar note, removing the subtext entirely from the mobile summary might look less jarring, as it is now, that mobile summary looks somewhat unfinished alongisde the other modules? Though perhaps the correct text indentation/alignment would help, I'll comment on the patch about fixing that.

image.png (1×894 px, 167 KB)

Hey @kostajh - that's fine to only show the title on the mobile summary, will update now, The copy is all placeholder though and should be revised and updated as part of T322890: Positive Reinforcement: Impact module - finalize copy and QQQ descriptions for TranslateWiki.net which I'm going to finish in next couple of hours :)

kostajh changed the task status from In Progress to Open.Nov 24 2022, 9:07 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 858347 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: empty data screen

https://gerrit.wikimedia.org/r/858347

Change 861347 had a related patch set uploaded (by Kosta Harlan; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: inject username value in ErrorDisplay

https://gerrit.wikimedia.org/r/861347

Change 861347 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: inject username value in ErrorDisplay

https://gerrit.wikimedia.org/r/861347

Etonkovidova subscribed.

Checked on production (wmf.14) and betalabs (the screenshots below are from betalabs) :

Screen Shot 2023-01-03 at 12.35.24 PM.png (1×2 px, 160 KB)
Screen Shot 2023-01-03 at 12.59.16 PM.png (1×652 px, 107 KB)