Could it be that we’re falling into this Mac OS + Firefox scenario? Testing in Chrome or setting accessibility.tabfocus to 7 on Firefox seem to work well.

Regarding skipping the thumbnail as a focusable element I guess it's possible to implement but not sure if it's worth or desired. With the current implementation using the keyboard would have the same interaction as using a mouse or a touch device. I don't think it's needed to change anything right now for accessibility reasons unless we want to have a different accessible text for the article thumbnail than "Go to article". But since we don't have a thumbnail caption to use and the article title is right beside I think it's usable enough.

In T322841#8395400, @Sgs wrote:

Could it be that we’re falling into this Mac OS + Firefox scenario?

Ah, I see. OK, macOS seems implicated. But even after switching "Keyboard navigation" on, I still can't get tab focus for items in the article table list with Safari.

I had to check also the option Press Tab to highlight each item on a web page on Safari's Preferences > Advanced

In T322841#8422102, @Sgs wrote:

I had to check also the option Press Tab to highlight each item on a web page on Safari's Preferences > Advanced

then the behavior is like in Chrome or Firefox (see attachement). Could it be this in your tests as well?

Aha, right. When I check that, it works in Safari. Thanks!

Mind that if testing this in betalabs (like in the gif) while T323838: pageviewsUrl is missing in the server-side exported user impact data is not resolved will not allow to navigate to the pageviews link because the anchor does not have a href attribute.

Ack. T323838 should be resolved now.

I think the last item here is what @RHo commented on in T313274#8424377; one should be able to tab to the clock icon, and it should also open a tooltip with the explanatory text.

In T322841#8427122, @kostajh wrote:

I think the last item here is what @RHo commented on in T313274#8424377; one should be able to tab to the clock icon, and it should also open a tooltip with the explanatory text.

Yes please! Re-posting screenshots over here for convenience:
The clock icon tooltip should appear and behave in the same way as before in the original impact module, which is a pop-over info text that is shown either on hover or via keyboard select:

Expected:

Actual:

Change 862223 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: show popover instead of tooltip in the clock icon

https://gerrit.wikimedia.org/r/862223

Pushed a patch for this. Since our "popover" component (CInfoBox/CPopper) does not have yet the clipping arrow the informational text just displays above the clock icon. Hopefully that's fine for now @RHo ?

Test wiki created on Patch demo by RHo (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/21a27f92de/w

In T322841#8431227, @Sgs wrote:

Pushed a patch for this. Since our "popover" component (CInfoBox/CPopper) does not have yet the clipping arrow the informational text just displays above the clock icon. Hopefully that's fine for now @RHo ?

Hi @Sgs - I tried to create a patchdemo to have a quick look at this but am setill seeing the old impact module (I tried appending ?new-impact=1 but nothing happened):

It looks mainly fine for now, but had wanted to confirm that it appears on mouse hover over the clock as well? And secondly, if we should create a separate task to make the styling changes later (adding in the pointer arrow)?

In T322841#8433035, @RHo wrote:

In T322841#8431227, @Sgs wrote:

Pushed a patch for this. Since our "popover" component (CInfoBox/CPopper) does not have yet the clipping arrow the informational text just displays above the clock icon. Hopefully that's fine for now @RHo ?

Hi @Sgs - I tried to create a patchdemo to have a quick look at this but am setill seeing the old impact module (I tried appending ?new-impact=1 but nothing happened):

It looks mainly fine for now, but had wanted to confirm that it appears on mouse hover over the clock as well? And secondly, if we should create a separate task to make the styling changes later (adding in the pointer arrow)?

On Special:Impact, at least, the ?new-impact=1 query seems to work:

https://patchdemo.wmflabs.org/wikis/21a27f92de/w/index.php?title=Special:Impact/Patch_Demo&new-impact=1

In T322841#8433072, @kostajh wrote:

In T322841#8433035, @RHo wrote:

In T322841#8431227, @Sgs wrote:

Pushed a patch for this. Since our "popover" component (CInfoBox/CPopper) does not have yet the clipping arrow the informational text just displays above the clock icon. Hopefully that's fine for now @RHo ?

Hi @Sgs - I tried to create a patchdemo to have a quick look at this but am setill seeing the old impact module (I tried appending ?new-impact=1 but nothing happened):

It looks mainly fine for now, but had wanted to confirm that it appears on mouse hover over the clock as well? And secondly, if we should create a separate task to make the styling changes later (adding in the pointer arrow)?

On Special:Impact, at least, the ?new-impact=1 query seems to work:

https://patchdemo.wmflabs.org/wikis/21a27f92de/w/index.php?title=Special:Impact/Patch_Demo&new-impact=1

Although, it's not really that useful for testing the clock change, because we export static data instead of allowing it to be dynamically generated. Let me see about changing that.

In T322841#8433117, @kostajh wrote:

In T322841#8433072, @kostajh wrote:

In T322841#8433035, @RHo wrote:

In T322841#8431227, @Sgs wrote:

Pushed a patch for this. Since our "popover" component (CInfoBox/CPopper) does not have yet the clipping arrow the informational text just displays above the clock icon. Hopefully that's fine for now @RHo ?

Hi @Sgs - I tried to create a patchdemo to have a quick look at this but am setill seeing the old impact module (I tried appending ?new-impact=1 but nothing happened):

It looks mainly fine for now, but had wanted to confirm that it appears on mouse hover over the clock as well? And secondly, if we should create a separate task to make the styling changes later (adding in the pointer arrow)?

On Special:Impact, at least, the ?new-impact=1 query seems to work:

https://patchdemo.wmflabs.org/wikis/21a27f92de/w/index.php?title=Special:Impact/Patch_Demo&new-impact=1

Although, it's not really that useful for testing the clock change, because we export static data instead of allowing it to be dynamically generated. Let me see about changing that.

I made this patch to change how the impact services are overridden (or rather, fixing it so they are not overridden) in Patch Demo.

Change 862350 had a related patch set uploaded (by Kosta Harlan; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] NewImpact: show popover instead of tooltip in the clock icon

https://gerrit.wikimedia.org/r/862350

Change 862223 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: show popover instead of tooltip in the clock icon

https://gerrit.wikimedia.org/r/862223

Change 862350 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] NewImpact: show popover instead of tooltip in the clock icon

https://gerrit.wikimedia.org/r/862350