Change 864777 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: Add thanks and longest streak scorecards

https://gerrit.wikimedia.org/r/864777

Change 864805 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: Add thanks and longest streak scorecards

https://gerrit.wikimedia.org/r/864805

Change 864777 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] User impact: Add thanks and longest streak scorecards

Reason:

reworked in I1e697eb2b354b29b1cfb697c9424beaa89410f1d

https://gerrit.wikimedia.org/r/864777

Do we care about 0 thanks not necessarily being true? We are only counting mainspace edits so it's not that unlikely that someone would e.g. make a talkpage comment and get thanked for it while still having 0 mainspace edits.

In T322850#8445575, @Tgr wrote:

Do we care about 0 thanks not necessarily being true? We are only counting mainspace edits so it's not that unlikely that someone would e.g. make a talkpage comment and get thanked for it while still having 0 mainspace edits.

cc @KStoller-WMF @KieranMcCann

In T322850#8445575, @Tgr wrote:

Do we care about 0 thanks not necessarily being true? We are only counting mainspace edits so it's not that unlikely that someone would e.g. make a talkpage comment and get thanked for it while still having 0 mainspace edits.

After rEGRE53819f929d34: User impact: Do not show impact module if user has no mainspace edits this is not true anymore since we fetch and use the data unconditionally, so thanks do get displayed even if the user has no edits.

@KieranMcCann @KStoller-WMF I'm unsure about the choice of – to indicate "null" or "not available" or "not applicable". Will – work well across all languages? Is there an icon, or a short text string (e.g. n/a), that we can use here?

In T322850#8484936, @kostajh wrote:

@KieranMcCann @KStoller-WMF I'm unsure about the choice of – to indicate "null" or "not available" or "not applicable". Will – work well across all languages? Is there an icon, or a short text string (e.g. n/a), that we can use here?

Thanks for always being so detail-oriented and considering localization challenges!
I agree that – seems imperfect, although I'm not sure "null", "not available", or "not applicable" seems very user-friendly either. But I suppose that could at least be localized... I'll check in with Ambassadors after break to see if they have any thoughts on this so we at least have more perspectives from other language wikis.

In T322850#8484936, @kostajh wrote:

@KieranMcCann @KStoller-WMF I'm unsure about the choice of – to indicate "null" or "not available" or "not applicable". Will – work well across all languages? Is there an icon, or a short text string (e.g. n/a), that we can use here?

Ambassadors discussed about this dash during their weekly meeting. A dash would be understood for all cultures represented in the meeting. However, two questions arose:

• understanding would be easier if we have a descriptive term instead of a dash, like "0 days" or "n/a"
• what about screen readers? A dash has multiple meanings and might not be well understood.

In T322850#8513662, @Trizek-WMF wrote:

Ambassadors discussed about this dash during their weekly meeting. A dash would be understood for all cultures represented in the meeting. However, two questions arose:

• understanding would be easier if we have a descriptive term instead of a dash, like "0 days" or "n/a"
• what about screen readers? A dash has multiple meanings and might not be well understood.

My preference would be for “0 days” as this makes most sense in plain language. But is there any instance that would be incorrect? For instance would there be an instance where that value couldn’t be shown but the value might not be zero?

0 seems to be safe: it can't be negative, and as the user edits, it will increase to 1 (and remain as 1 for most user cases).

Change 864805 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: Add thanks and longest streak scorecards to the unactivated state

https://gerrit.wikimedia.org/r/864805

Checked in testwiki wmf.22 and wmf.21

(1)

Scenario	Desktop	Mobile	Mobile summary (no change)
Scenario A: Person has 0 edits, Suggested edits is enabled. – Use the existing empty state + scorecards

Desktop wmf.21	Mobile wmf.21	Mobile summary (no change) wmf.21

For @RHo review:

• On Desktop the footer on the mockup has "Start with a few Suggested edits..." vs the current production footer has suggested edits in bold and not capitalized
• "See suggested edits" button on Mobile is not blue
• Mobile summary on production has a different footer in the mockup - (production) "Start with few suggested edits..." vs (mockup) "Once you start editing..." Should it be changed to match the mockup?

Questions:

• first time landing on Impact module overlay in mobile will display a message about a new Impact module. Should it be displayed for the unactivated state? Or the wording should be changed?

• frwiktionary wmf.21 displays the old Impact module. No plans to enable the new Impact module there?

In T322850#8596330, @Etonkovidova wrote:

Checked in testwiki wmf.22 and wmf.21

(1)

Scenario	Desktop	Mobile	Mobile summary (no change)
Scenario A: Person has 0 edits, Suggested edits is enabled. – Use the existing empty state + scorecards

Desktop wmf.21	Mobile wmf.21	Mobile summary (no change) wmf.21

For @RHo review:

• On Desktop the footer on the mockup has "Start with a few Suggested edits..." vs the current production footer has suggested edits in bold and not capitalized
• "See suggested edits" button on Mobile is not blue
• Mobile summary on production has a different footer in the mockup - (production) "Start with few suggested edits..." vs (mockup) "Once you start editing..." Should it be changed to match the mockup?

Thanks @Etonkovidova! You are correct that the mobile button should be updated to the progressive primary blue, so @Sgs I'm putting back to "In-progress" get updated, thanks!
As for the copy though, we never updated the copy as part of the task so ignore differences from mock to prod.

From figma spec:

---

Questions:

• first time landing on Impact module overlay in mobile will display a message about a new Impact module. Should it be displayed for the unactivated state? Or the wording should be changed?

This should only appear for existing newcomers (per criteria in T323619) so I think it's OK to leave it since realistically it won't show up for many people (it would be existing newcomers who have never made an edit going to this for the first time).

• frwiktionary wmf.21 displays the old Impact module. No plans to enable the new Impact module there?

Maybe a question for @Trizek-WMF?

In T322850#8597151, @RHo wrote:

• frwiktionary wmf.21 displays the old Impact module. No plans to enable the new Impact module there?

Maybe a question for @Trizek-WMF?

As the new impact module is only available on a few wikis for test purposes, Wiktionary will get the new impact module along with all other wikis.

But first, we will have to fix it: T329192: When Suggested edits are unavailable, new Impact module stays in unactivated state. ;)