Page MenuHomePhabricator

Search improvements - not closed QuickView disregards article snippet position
Closed, ResolvedPublic

Description

Steps to reproduce in enwiki betalabs:

  1. As a logged user go to Special:Search page and perform a search for test
  2. Click on the first article snippet in the search results - the QuickView will be displayed at the top of the search results; the position will be on the side of the clicked snippet - CORRECT.
  3. Without closing the QuickView, scroll down and click any article snippet at the end of search results. The QuickView won't be displayed.

If you scroll up, the QuickView for the article at the bottom of the page will be displayed at the top.

The animated gif shows

  • search results for the search term test
  • the first results - the article snippet for Test is clicked - the QuickView is displayed correctly.
  • a user doesn't close the QuickView in the above step; a user scrolls down
  • a user clicks on Unix article snippet - the QuickView is not displayed at the same position where the article is. The QuickView is displayed at the top of the page.

first_second_results5.gif (785×1 px, 1 MB)

Note:

  • the issue is present if the steps are done for the article snippet at the bottom. Then the QuickView would be "stuck" at the bottom of the page.

Event Timeline

Testing notes (to check after the fix)

  • display search results
  • scroll down to the bottom of the page
  • start clicking on the snippets one by one moving up the search result. This is to see how well the QuickView will adjust the position.
vadim-kovalenko changed the task status from Open to In Progress.Nov 21 2022, 9:44 AM
vadim-kovalenko claimed this task.

Change 859546 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/core@master] Search improvements - not closed QuickView disregards article snippet position

https://gerrit.wikimedia.org/r/859546

Change 859547 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/extensions/SearchVue@master] Search improvements - not closed QuickView disregards article snippet position

https://gerrit.wikimedia.org/r/859547

Change 859560 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/extensions/SearchVue@master] Search improvements - not closed QuickView disregards article snippet position

https://gerrit.wikimedia.org/r/859560

@SimoneThisDot pls take a look at this patch - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SearchVue/+/859560/ It has way less refactoring but solves the problem with incorrect position while switching between quick views.

Change 859560 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search improvements - not closed QuickView disregards article snippet position

https://gerrit.wikimedia.org/r/859560

Change 859547 abandoned by Vadim Kovalenko:

[mediawiki/extensions/SearchVue@master] Search improvements - not closed QuickView disregards article snippet position

Reason:

This has been fixed in Ie5de85d3b95bf036967aa864644fed414b3fd484

https://gerrit.wikimedia.org/r/859547

Change 859546 abandoned by Vadim Kovalenko:

[mediawiki/core@master] Search improvements - not closed QuickView disregards article snippet position

Reason:

This has been fixed in Ie5de85d3b95bf036967aa864644fed414b3fd484

https://gerrit.wikimedia.org/r/859546

Checked in betalabs - the issue is fixed.