ApiBlockInfoTrait should indicate the type of the block
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Tgr
	Nov 11 2022, 8:29 PM

Description

Currently, ApiBlockInfoTrait::getBlockDetails() gives identical looking information for a local and a global block. Since the information includes the database ID, it really should specify which database the ID is for, ie. there should be some sort of block type field.

This would probably require adding a type field to the Block interface.

Related Objects

Mentioned In: T318891: Remove usage of User::isBlockedGlobally and User::getGlobalBlock in Thanks

Event Timeline

Tgr created this task.Nov 11 2022, 8:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2022, 8:29 PM

Tgr mentioned this in T318891: Remove usage of User::isBlockedGlobally and User::getGlobalBlock in Thanks.Nov 11 2022, 8:30 PM

Tgr updated the task description. (Show Details)Nov 11 2022, 8:33 PM

Another use case for a type field in Block is that BlockManager::getUniqueBlocks() would deduplicate any two blocks which return the same ID, even if e.g. one is a local block and the other is a global block.

ApiBlockInfoTrait should indicate the type of the blockOpen, Needs TriagePublicActions

Description

Related Objects

Event Timeline

ApiBlockInfoTrait should indicate the type of the block
Open, Needs TriagePublic
Actions