Page MenuHomePhabricator

Graduate Realtime Preview feature from Beta to being available for everyone
Closed, ResolvedPublic3 Estimated Story Points

Description

Key Dates

This will be done during the deployment window on Monday, January 9, and so it will be available on all wikis at that time.
The same config change will remove the beta feature and enable RTP by default everywhere.

As soon as the config change has been deployed we'll edit gadgets-definition on plwiki and remove the gadget (T313420 has details).

Acceptance Criteria

Realtime Preview should be available on all wikis, including Polish Wikipedia (where it is currently deployed as a default-on gadget).

Event Timeline

As things stand, this will not include plwikipedia. Enabling it there is tracked in T313420, and can happen before or after disabling the Beta Feature. @NRodriguez: Should that one be done first?

The decision is to deploy it on plwiki at the same time.

Also, this is a config-only change, and so won't be deployed in the train. This means that RTP will be enabled everywhere on Monday 9 Jan, during whichever of the three backport windows we choose. Is that okay?

Change 868816 had a related patch set uploaded (by Samwilson; author: Samwilson):

[operations/mediawiki-config@master] Remove Beta Feature for Realtime Preview and enable on plwiki

https://gerrit.wikimedia.org/r/868816

I've scheduled the change for 2023-01-09 08:00 UTC.

Change 877189 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Add config var to disable Beta Feature

https://gerrit.wikimedia.org/r/877189

The deployment was not able to happen today, because I overlooked the fact that unwhitelisting the RTP beta feature does not in fact enable it. The above patch adds a new config variable to make it possible to disable the beta feature.

We can review the deployment schedule tomorrow.

Change 877189 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Add config var to disable Beta Feature

https://gerrit.wikimedia.org/r/877189

Deployment now scheduled for Thursday 12th at 21:00 UTC. The above new Beta Feature config variable will be available on all wikis by then.

Change 868816 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove Beta Feature for Realtime Preview and enable on plwiki

https://gerrit.wikimedia.org/r/868816

Mentioned in SAL (#wikimedia-operations) [2023-01-12T21:05:35Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:868816|Remove Beta Feature for Realtime Preview and enable on plwiki (T323033)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-12T21:07:07Z] <thcipriani@deploy1002> thcipriani and samwilson: Backport for [[gerrit:868816|Remove Beta Feature for Realtime Preview and enable on plwiki (T323033)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-12T21:16:19Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:868816|Remove Beta Feature for Realtime Preview and enable on plwiki (T323033)]] (duration: 10m 43s)

Testing on production

Before the deploy, I setup two users with different beta feature preferences:

  • User 1 had the RTP beta feature enabled on enwiki but disabled on frwiki
  • User 2 had RTP beta feature globally enabled but locally disabled on frwiki

After the deploy, I tested that RTP was available when editing for both users and did not appear in the beta features tab on Special:Preferences and Special:GlobalPreferences.

User 1 tested enwiki, frwiki and plwiki.

User 2 tested dewiki, frwiki and plwiki.

I also tested that RTP was enabled for an anonymous user on commons and plwiki.

Testing the new settings locally

Locally, I tested different combinations of $wgWikiEditorRealtimePreview, $wgWikiEditorRealtimePreviewBeta and having the BetaFeatures extension installed or not.

When $wgWikiEditorRealtimePreview is true, RTP is enabled for all users (including anonymous users). Unless $wgWikiEditorRealtimePreviewBeta is true and BetaFeatures installed, in which case it is only enabled for users who set it in their beta features and is disabled for anonymous users.

When $wgWikiEditorRealtimePreview is false, RTP is disabled in all circumstances and does not appear in the beta features settings.

Test environments:

Also adding to Dom's testing with the following below with RTP working:

Mostly anonymous unless I have to log in to things like WikiTech to have permission to edit and validate the RTP.

OS: macOS 13.0
Browser: Chrome 108

Testing in PROD

  • Wikipedia, en, fa, ru, fr, zh, kw, bug, tl, mhz, cr, pl
  • Wiktionary- en, id
  • Wikiquote- en, tr
  • Wikibooks- es, hi
  • Wikisource- de, he
  • Wikinews- ja, fr
  • Wikiversity- it, el
  • Wikispecies -en
  • MediaWiki- en
  • Wikidata- en
  • Wikimedia Commons- en
  • Wikivoyage- pt
  • Wikimedia Meta-Wiki - en
  • Wikimedia Incubator- en
  • Wikitech- en