Maniphest T323055

ZLabelsBlock: Saving and loading empty string aliases
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

• AdesojiThisDot

Authored By

	• JKieserman
	Nov 14 2022, 6:08 PM

Tags

Referenced Files

None

Subscribers

Description

Description

Steps to reproduce:

go to https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject
add one or more alias boxes, but do not put any text in them
create a valid ZObject of any kind
click save

Observed behavior:
The ZObject is saved and reloaded, with one or more empty ("") aliases

Expected behavior (Acceptance criteria):

empty aliases are not saved with the ZObject

Devices and Design (URLs or screenshots, if applicable):

Desktop: ...
Small screens/mobile: ...

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	prevent chips container from emitting empty value	mediawiki/extensions/WikiLambda	master	+229 -99

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	PRODUCTION ERROR	Jdforrester-WMF	T344206 Special:MathStatus exception error on Wikifunctions
		Resolved		Jdforrester-WMF	T342865 Post-creation work for wikifunctionswiki
		Resolved		BTullis	T289316 Prepare and check storage layer for Wikifunctions.org (new public content wiki)
		Resolved		Jdforrester-WMF	T275945 Create Wikifunctions.org
		Resolved		Jdforrester-WMF	T299176 Phase Theta – Root task
		Resolved		Nik.xyz.in	T340774 e2e tests for DefaultView: Fix and re-enable once DefaultView is fully finished
		Resolved		DVrandecic	T324802 Phase θ Goal 5: Fallback view
		Resolved	BUG REPORT	• AdesojiThisDot	T323055 ZLabelsBlock: Saving and loading empty string aliases

Event Timeline

• JKieserman created this task.Nov 14 2022, 6:08 PM

DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 15 2022, 7:36 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 15 2022, 8:43 PM

• AdesojiThisDot claimed this task.Nov 16 2022, 9:50 AM

Change 857690 had a related patch set uploaded (by AdesojiThisDot; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] prevent chips container from emitting empty value

https://gerrit.wikimedia.org/r/857690

gerritbot added a project: Patch-For-Review.Nov 16 2022, 4:33 PM

gengh moved this task from Ready: G4. Function view to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 23 2022, 8:12 AM

Change 857690 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] prevent chips container from emitting empty value

https://gerrit.wikimedia.org/r/857690

Maintenance_bot removed a project: Patch-For-Review.Nov 30 2022, 2:30 PM

• RWambua-WMF added a parent task: T324802: Phase θ Goal 5: Fallback view.Dec 8 2022, 11:51 PM

• AdesojiThisDot moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Dec 12 2022, 5:52 AM

Reviewed and the empty aliases are not being saved.