Page MenuHomePhabricator

ZLabelsBlock: Saving and loading empty string aliases
Closed, ResolvedPublicBUG REPORT

Description

Description

Steps to reproduce:

  1. go to https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject
  2. add one or more alias boxes, but do not put any text in them
  3. create a valid ZObject of any kind
  4. click save

Observed behavior:
The ZObject is saved and reloaded, with one or more empty ("") aliases

Expected behavior (Acceptance criteria):

  • empty aliases are not saved with the ZObject

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Event Timeline

Change 857690 had a related patch set uploaded (by AdesojiThisDot; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] prevent chips container from emitting empty value

https://gerrit.wikimedia.org/r/857690

Change 857690 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] prevent chips container from emitting empty value

https://gerrit.wikimedia.org/r/857690

DVrandecic subscribed.

Reviewed and the empty aliases are not being saved.