Page MenuHomePhabricator

Fix RMessageView crash
Closed, ResolvedPublic

Description

There's an existing crash that we're seeing in the 7.0.0 TestFlight beta:

CoreAutoLayout: ResolveConstraintArguments + 952
...
-[RMessageView setupLayout]

We are using this toast class much more in the new talk pages, so even though this is not a new crash, I think it's worth looking at now for this release to try and reproduce and fix.

Event Timeline

Tsevener moved this task from Needs Code Review to Waiting for Build on the ios-app-v7.0 board.

We couldn't reproduce, but we tried some fixes anyway. For QA, just keep an eye out for any regressions in our toast banners (No internet connection, talk page subscribe/unsubscribe messages, etc). The fix will be available in TestFlight build 7.0.0 (2010).

@Tsevener Testing on 7.0.0 (2010), I noticed a couple of small issues, but no crashes.

Here is what I saw:

  1. Revision History, both talk page and articles: With no internet connection, tapping on Edit/Revision history causes the no internet connection banner to appear 2 to 3 times.
  2. With no internet connection, the following screens fail to load and no banner appears: Page Information, Contributions, User groups, Logs, Permanent link, and What links here.

@ABorbaWMF thanks for finding those! I think these particular things are existing issues. Can you spin off a couple of separate bug tasks for them?

  1. I can reproduce multiple error banners on the revision screen in the App Store build (going from any article's footer > edit history). That screen makes many API calls so we're probably seeing one for each failed call. We might just need to see if there's some way to work on the toast system so that duplicate ones don't appear on top of each other.
  2. This one I can recreate by going to any in-app web view, which most of these overflow menu talk page links go to. In the current App Store build, go to an article talk page, you'll see the same issue. For this we'll want to see if we can fix whatever bug is causing those load failure toasts to not show. I do see that we attempt to present one in case of a failure in that area, but clearly it's not working. Thanks!

I wrote up the small issues above in separate tickets. Moving this one to sign-off

JMinor claimed this task.
JMinor subscribed.

Thanks for the followups.