Page MenuHomePhabricator

"Learn more about this page" button doesn't appear as expected in mobile DiscussionTools
Closed, ResolvedPublic

Description

"Learn more about this page" doesn't appear as expected in mobile DiscussionTools.

This page has the button but shouldn't: https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:No_lede_content

This page doesn't have the button but should: https://en.m.wikipedia.beta.wmflabs.org/wiki/User_talk:Yatu

Related Objects

Event Timeline

It seems that the changes we've done for T312309 and for T314714 are not compatible with each other.

Change 857080 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix condition for lede button to consider new wrappers

https://gerrit.wikimedia.org/r/857080

Change 857080 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix condition for lede button to consider new wrappers

https://gerrit.wikimedia.org/r/857080

Change 858309 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.10] CommentFormatter: Fix condition for lede button to consider new wrappers

https://gerrit.wikimedia.org/r/858309

Change 858309 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.10] CommentFormatter: Fix condition for lede button to consider new wrappers

https://gerrit.wikimedia.org/r/858309

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:13:49Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:858308|Make "Add topic" button sticky (T316175)]], [[gerrit:858309|CommentFormatter: Fix condition for lede button to consider new wrappers (T323171)]], [[gerrit:858310|Remove override for Minerva hiding .tmbox, no longer needed (T257394)]], [[gerrit:858311|CommentFormatter: Fix condition for lede button to consider table of contents (T323241)]], [[gerrit:858312

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:14:13Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:858308|Make "Add topic" button sticky (T316175)]], [[gerrit:858309|CommentFormatter: Fix condition for lede button to consider new wrappers (T323171)]], [[gerrit:858310|Remove override for Minerva hiding .tmbox, no longer needed (T257394)]], [[gerrit:858311|CommentFormatter: Fix condition for lede button to consider table of contents (T323241)]], [[gerr

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:50:35Z] <urbanecm@deploy1002> Started scap: 4e419212: f659d88b: 65cd6881: 96e86cf: 5b94aca: 7a06c4b98: DiscussionTools, GlobalUsage, MinervaNeue backports (T316175, T323171, T257394, T323241)

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:55:04Z] <urbanecm@deploy1002> Finished scap: 4e419212: f659d88b: 65cd6881: 96e86cf: 5b94aca: 7a06c4b98: DiscussionTools, GlobalUsage, MinervaNeue backports (T316175, T323171, T257394, T323241) (duration: 04m 29s)

It disappeared after I purged the page (https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:No_lede_content?action=purge). Looks like it was just a cached rendering generated by the previous, buggy code.

EAkinloose added a subscriber: EAkinloose.

It disappeared after I purged the page (https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:No_lede_content?action=purge). Looks like it was just a cached rendering generated by the previous, buggy code.

I have been able to confirm this as well.