Page MenuHomePhabricator
Create Task
Maniphest T323206

Allow statement guid to be empty (optional) and show it as "None" in the UI
Closed, ResolvedPublic
Actions

Description

If the mismatch has no data for the wikidata value, then it should show as "None" in the UI

  • Double check with with UX (@Sarai-WMDE) on whether we want the "None" to be in italics or some shade of gray or something, to differentiate it from the plain string "None"

Related Objects
Search...

Event Timeline

Michael created this task.Nov 16 2022, 10:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2022, 10:40 AM
noarave mentioned this in T313468: allow reporting of mismatches with empty Wikidata value.Nov 16 2022, 12:08 PM
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Nov 16 2022, 12:34 PM
guergana.tzatchkova subscribed.Nov 17 2022, 3:33 PM

As indicated by @Sarai-WMDE

I originally didn't think that using a different style was necessary, but it might support recognition: we should use the color #72777d (font-color-disabled). I'd hope this would bring enough differentiation (so my assumption is that italics are not needed)

guergana.tzatchkova claimed this task.Nov 17 2022, 3:33 PM
guergana.tzatchkova moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
guergana.tzatchkova added a comment.Nov 17 2022, 4:53 PM

Plan of action:

  • in ValidateCSV, make the statement_guid not required and validate that if statetament_guid is not present then wikidata_value should also be empty.
  • display none when there is no statement_guid and wikidata_value
guergana.tzatchkova added a comment.Nov 17 2022, 5:45 PM

https://github.com/wmde/wikidata-mismatch-finder/pull/475

guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Nov 23 2022, 1:43 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Nov 25 2022, 11:42 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Our work done on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Dec 20 2022, 7:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL