⚓ T323241 "Learn more about this page" button always appears when the page has a table of contents in mobile DiscussionTools

	Subject	Author	Repo	Branch	Lines +/-
	CommentFormatter: Fix condition for lede button to consider table of contents	Bartosz Dziewoński	mediawiki/extensions/DiscussionTools	wmf/1.40.0-wmf.10	+13 -13
	CommentFormatter: Fix condition for lede button to consider table of contents	Bartosz Dziewoński	mediawiki/extensions/DiscussionTools	master	+13 -13

• matmarex created this task.Nov 16 2022, 9:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2022, 9:16 PM

• matmarex claimed this task.Nov 16 2022, 9:16 PM

• matmarex added a project: Editing-team (Kanban Board).

Change 857778 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix condition for lede button to consider table of contents

https://gerrit.wikimedia.org/r/857778

gerritbot added a project: Patch-For-Review.Nov 16 2022, 9:20 PM

• matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Nov 16 2022, 9:20 PM

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 16 2022, 10:03 PM

DLynch added a project: Editing QA.

Change 857778 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix condition for lede button to consider table of contents

https://gerrit.wikimedia.org/r/857778

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2022, 10:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 16 2022, 11:01 PM

Change 858311 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.10] CommentFormatter: Fix condition for lede button to consider table of contents

https://gerrit.wikimedia.org/r/858311

gerritbot added a project: Patch-For-Review.Nov 17 2022, 1:15 PM

Change 858311 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.10] CommentFormatter: Fix condition for lede button to consider table of contents

https://gerrit.wikimedia.org/r/858311

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:13:49Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:858308|Make "Add topic" button sticky (T316175)]], [[gerrit:858309|CommentFormatter: Fix condition for lede button to consider new wrappers (T323171)]], [[gerrit:858310|Remove override for Minerva hiding .tmbox, no longer needed (T257394)]], [[gerrit:858311|CommentFormatter: Fix condition for lede button to consider table of contents (T323241)]], [[gerrit:858312

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:14:13Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:858308|Make "Add topic" button sticky (T316175)]], [[gerrit:858309|CommentFormatter: Fix condition for lede button to consider new wrappers (T323171)]], [[gerrit:858310|Remove override for Minerva hiding .tmbox, no longer needed (T257394)]], [[gerrit:858311|CommentFormatter: Fix condition for lede button to consider table of contents (T323241)]], [[gerr

Maintenance_bot removed a project: Patch-For-Review.Nov 17 2022, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:50:35Z] <urbanecm@deploy1002> Started scap: rSMIN4e4192126b55: f659d88b: 65cd6881: 96e86cf: 5b94aca: 7a06c4b98: DiscussionTools, GlobalUsage, MinervaNeue backports (T316175, T323171, T257394, T323241)

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:55:04Z] <urbanecm@deploy1002> Finished scap: rSMIN4e4192126b55: f659d88b: 65cd6881: 96e86cf: 5b94aca: 7a06c4b98: DiscussionTools, GlobalUsage, MinervaNeue backports (T316175, T323171, T257394, T323241) (duration: 04m 29s)

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 17 2022, 3:00 PM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Nov 17 2022, 4:06 PM

• Whatamidoing-WMF mentioned this in T323341: unnecessary button on mobile talk pages.Nov 18 2022, 5:00 AM

✅ Learn more about this page button should only show up when there is content in the lede section in mobile DiscussionTools

With Lede content and ToC

Screenshot 2022-11-26 at 01.30.23.png (3,018×1,764 px, 701 KB)

Screenshot 2022-11-26 at 01.31.00.png (590×1,268 px, 118 KB)

Without Lede content and ToC

Screenshot 2022-11-26 at 01.32.47.png (2,732×1,366 px, 372 KB)

Screenshot 2022-11-26 at 01.32.06.png (592×1,268 px, 120 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 26 2022, 1:55 AM

ppelberg closed this task as Resolved.Dec 2 2022, 12:36 AM

"Learn more about this page" button always appears when the page has a table of contents in mobile DiscussionTools
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

	F35820199: Screenshot 2022-11-26 at 01.32.06.png
	Nov 26 2022, 1:54 AM

	F35820201: Screenshot 2022-11-26 at 01.32.47.png
	Nov 26 2022, 1:54 AM

	F35820195: Screenshot 2022-11-26 at 01.31.00.png
	Nov 26 2022, 1:54 AM

	F35820192: Screenshot 2022-11-26 at 01.30.23.png
	Nov 26 2022, 1:54 AM

"Learn more about this page" button always appears when the page has a table of contents in mobile DiscussionToolsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

"Learn more about this page" button always appears when the page has a table of contents in mobile DiscussionTools
Closed, ResolvedPublic
Actions