Remove extra spacing from username/create account link
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• alexhollender_WMF
	Nov 16 2022, 10:42 PM

Description

NOTE: Please read https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/858627/2/resources/skins.vector.styles/components/StickyHeader.less#121 and T323176#8406306 before you begin work on this ticket.

Description

the username and create account links have an extra 8px of margin on either side:

Screen Shot 2022-10-07 at 3.06.39 PM.png (1×2 px, 302 KB)

To-do

remove extra spacing

Notes

In case it's for some reason helpful, this was noted in T320101#8301450

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[Visual change] Limit link spacing in user links	mediawiki/skins/Vector	master	+8 -5
	Remove extra spacing from username/create account link	mediawiki/skins/Vector	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T317884 [EPIC] Vector 2022 post-deployment work
Declined	ovasileva	T317632 [EPIC] Visual refinements pt2
Resolved	Jdlrobson	T323244 Remove extra spacing from username/create account link

Event Timeline

• alexhollender_WMF created this task.Nov 16 2022, 10:42 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.Nov 16 2022, 10:56 PM

We should remove this line:
https://github.com/wikimedia/Vector/blob/master/resources/skins.vector.styles/components/UserLinks.less#L73

Jdlrobson set the point value for this task to 1.Nov 16 2022, 11:18 PM

ovasileva triaged this task as Medium priority.Nov 17 2022, 3:24 PM

ovasileva edited projects, added Web-Team-Backlog-Archived; removed Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2).Nov 17 2022, 3:29 PM

ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog-Archived board.

bwang mentioned this in T323176: [S] Sticky header icon buttons are missing padding.Nov 18 2022, 5:43 PM

Jdlrobson updated the task description. (Show Details)Nov 21 2022, 7:19 PM

Jdlrobson updated the task description. (Show Details)Nov 21 2022, 7:31 PM

Jdlrobson edited parent tasks, added: T317632: [EPIC] Visual refinements pt2; removed: T322673: Test VectorVisualEnhancementsNext flag.Nov 23 2022, 4:06 PM

Jdlrobson moved this task from Incoming to Visual Enhancements / Layout on the Vector 2022 board.Nov 28 2022, 5:48 PM

Sushrith_Bogi claimed this task.Apr 30 2023, 5:18 AM

Change 912401 had a related patch set uploaded (by Sushrith Bogi; author: Sushrith Bogi):

[mediawiki/skins/Vector@master] Remove extra spacing from username/create account link

https://gerrit.wikimedia.org/r/912401

gerritbot added a project: Patch-For-Review.Apr 30 2023, 5:21 AM

Thanks for the patch @Sushrith_Bogi I've added it to our review queue for next week.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 2:23 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 5:09 PM

Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 8:27 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/30ff4a6d1b/w

bwang moved this task from Design Review to Needs More Work on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 10:04 PM

• nray reassigned this task from Sushrith_Bogi to Edtadros.May 11 2023, 4:43 PM

• nray moved this task from Needs More Work to QA on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.

• nray moved this task from QA to Design Review on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.

• nray added a subscriber: Sushrith_Bogi.

Change 912401 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove extra spacing from username/create account link

https://gerrit.wikimedia.org/r/912401

Maintenance_bot removed a project: Patch-For-Review.May 11 2023, 11:11 PM

Looks good to me from design QA perspective

• KieranMcCann moved this task from Design Review to QA on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.May 12 2023, 8:15 AM

This caused an issue that was flagged by Pixel so I reverted the change:

before	after
{F36994336}

Change 919389 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Limit link spacing in user links to below desktop viewports

https://gerrit.wikimedia.org/r/919389

gerritbot added a project: Patch-For-Review.May 12 2023, 5:56 PM

bwang removed Edtadros as the assignee of this task.May 12 2023, 5:56 PM

bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.May 12 2023, 7:33 PM

Change 919389 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Visual change] Limit link spacing in user links

https://gerrit.wikimedia.org/r/919389

Maintenance_bot removed a project: Patch-For-Review.May 12 2023, 8:12 PM

Jdlrobson assigned this task to Edtadros.May 15 2023, 5:13 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 8:01 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Extra spacing should be removed from username/create account link

Screenshot 2023-05-16 at 2.50.06 PM.png (143×350 px, 14 KB)

Screenshot 2023-05-16 at 2.49.24 PM.png (134×356 px, 13 KB)

LGTM! Thanks!

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/30ff4a6d1b/w/~~

	F37001759: Screenshot 2023-05-16 at 2.49.24 PM.png
	May 16 2023, 9:51 PM

	F37001758: Screenshot 2023-05-16 at 2.50.06 PM.png
	May 16 2023, 9:51 PM

	F35553707: Screen Shot 2022-10-07 at 3.06.39 PM.png
	Nov 16 2022, 10:42 PM
	File Not Attached

	F36994333: image.png
	May 12 2023, 3:25 PM

Remove extra spacing from username/create account linkClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Description

To-do

Notes

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

QA Steps

Remove extra spacing from username/create account link
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...