Page MenuHomePhabricator
Create Task
Maniphest T323290

"Postcondition failed: Revision had no page" / "PageRecord for page {page} revision {revision} not found" (in DiscussionTools)
Open, Needs TriagePublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Assert\PostconditionException: Postcondition failed: Revision had no page
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.8/vendor/wikimedia/assert/src/Assert.php(203)
#0 /srv/mediawiki/php-1.40.0-wmf.8/extensions/DiscussionTools/includes/Hooks/HookUtils.php(135): Wikimedia\Assert\Assert::postcondition(boolean, string)
#1 /srv/mediawiki/php-1.40.0-wmf.8/extensions/DiscussionTools/includes/Hooks/DataUpdatesHooks.php(50): MediaWiki\Extension\DiscussionTools\Hooks\HookUtils::parseRevisionParsoidHtml(MediaWiki\Revision\RevisionStoreRecord)
#2 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/MWCallableUpdate.php(38): MediaWiki\Extension\DiscussionTools\Hooks\DataUpdatesHooks->MediaWiki\Extension\DiscussionTools\Hooks\{closure}()
#3 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(474): MWCallableUpdate->doUpdate()
#4 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/RefreshSecondaryDataUpdate.php(103): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#5 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(474): RefreshSecondaryDataUpdate->doUpdate()
#6 /srv/mediawiki/php-1.40.0-wmf.8/includes/Storage/DerivedPageDataUpdater.php(1801): DeferredUpdates::attemptUpdate(RefreshSecondaryDataUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#7 /srv/mediawiki/php-1.40.0-wmf.8/includes/page/WikiPage.php(2136): MediaWiki\Storage\DerivedPageDataUpdater->doSecondaryDataUpdates(array)
#8 /srv/mediawiki/php-1.40.0-wmf.8/includes/jobqueue/jobs/RefreshLinksJob.php(243): WikiPage->doSecondaryDataUpdates(array)
#9 /srv/mediawiki/php-1.40.0-wmf.8/includes/jobqueue/jobs/RefreshLinksJob.php(152): RefreshLinksJob->runForTitle(Title)
#10 /srv/mediawiki/php-1.40.0-wmf.8/extensions/EventBus/includes/JobExecutor.php(79): RefreshLinksJob->run()
#11 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#12 {main}
Impact
Notes

Noticed one of these in recent logs.

Details

Request URL
https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add more details to "Revision had no page" errormediawiki/extensions/DiscussionToolsmaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

brennen created this task.Nov 17 2022, 4:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2022, 4:37 PM
Krinkle renamed this task from Wikimedia\Assert\PostconditionException: Postcondition failed: Revision had no page to PostconditionException: "Postcondition failed: Revision had no page" (in DiscussionTools).Nov 17 2022, 4:55 PM
Krinkle moved this task from Untriaged to Nov 2022 on the Wikimedia-production-error board.
Krinkle added a project: Editing-team.
matmarex subscribed.Nov 18 2022, 5:32 PM

Looks very rare, 5 occurrences in last 30 days: https://logstash.wikimedia.org/goto/e31cf3adaed983402761ca72828239e3

We've had this problem previously, where it was caused by some core code reading from replica instead of master: T289717. The rate of errors was much higher when that happened, though.

Or maybe someone has actually deleted the page while our code was trying to process it, the rate is low enough that it could be just that.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Dec 1 2022, 4:25 PM
ppelberg removed a project: Editing-team.
brennen moved this task from Backlog to Logs/Train on the User-brennen board.Dec 5 2022, 9:27 PM
brennen unsubscribed.Sep 11 2023, 7:23 PM
brennen added a comment.Jan 16 2025, 7:31 PM

Just noted a handful of these in 1.44.0-wmf.12 (T382363):

Error
labels.normalized_message
[{reqId}] {exception_url}   Wikimedia\Assert\PostconditionException: Postcondition failed: Revision had no page
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.12/vendor/wikimedia/assert/src/Assert.php(203)
#0/srv/mediawiki/php-1.44.0-wmf.12/extensions/DiscussionTools/includes/Hooks/HookUtils.php(135)Wikimedia\Assert\Assert::postcondition(bool, string)
#1/srv/mediawiki/php-1.44.0-wmf.12/extensions/DiscussionTools/includes/Hooks/DataUpdatesHooks.php(48)MediaWiki\Extension\DiscussionTools\Hooks\HookUtils::parseRevisionParsoidHtml(MediaWiki\Revision\RevisionStoreRecord, string)
#2/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/MWCallableUpdate.php(52)MediaWiki\Extension\DiscussionTools\Hooks\DataUpdatesHooks->MediaWiki\Extension\DiscussionTools\Hooks\{closure}(string)
#3/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/DeferredUpdates.php(462)MediaWiki\Deferred\MWCallableUpdate->doUpdate()
#4/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/RefreshSecondaryDataUpdate.php(112)MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\MWCallableUpdate)
#5/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/DeferredUpdates.php(462)MediaWiki\Deferred\RefreshSecondaryDataUpdate->doUpdate()
#6/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/DeferredUpdates.php(204)MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\RefreshSecondaryDataUpdate)
#7/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/DeferredUpdates.php(291)MediaWiki\Deferred\DeferredUpdates::run(MediaWiki\Deferred\RefreshSecondaryDataUpdate)
#8/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/DeferredUpdatesScope.php(240)MediaWiki\Deferred\DeferredUpdates::MediaWiki\Deferred\{closure}(MediaWiki\Deferred\RefreshSecondaryDataUpdate, int)
#9/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/DeferredUpdatesScope.php(172)MediaWiki\Deferred\DeferredUpdatesScope->processStageQueue(int, int, Closure)
#10/srv/mediawiki/php-1.44.0-wmf.12/includes/deferred/DeferredUpdates.php(310)MediaWiki\Deferred\DeferredUpdatesScope->processUpdates(int, Closure)
#11/srv/mediawiki/php-1.44.0-wmf.12/includes/MediaWikiEntryPoint.php(676)MediaWiki\Deferred\DeferredUpdates::doUpdates()
#12/srv/mediawiki/php-1.44.0-wmf.12/includes/MediaWikiEntryPoint.php(498)MediaWiki\MediaWikiEntryPoint->restInPeace()
#13/srv/mediawiki/php-1.44.0-wmf.12/includes/MediaWikiEntryPoint.php(456)MediaWiki\MediaWikiEntryPoint->doPostOutputShutdown()
#14/srv/mediawiki/php-1.44.0-wmf.12/includes/MediaWikiEntryPoint.php(211)MediaWiki\MediaWikiEntryPoint->postOutputShutdown()
#15/srv/mediawiki/php-1.44.0-wmf.12/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#16/srv/mediawiki/w/index.php(3)require(string)
#17{main}
• Agusbou2015 subscribed.Jan 16 2025, 8:24 PM
Reedy subscribed.Mar 2 2025, 9:43 PM
Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Assert\PostconditionException: Postcondition failed: Revision had no page
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.18/vendor/wikimedia/assert/src/Assert.php(203)
#0/srv/mediawiki/php-1.44.0-wmf.18/extensions/DiscussionTools/includes/Hooks/HookUtils.php(136)Wikimedia\Assert\Assert::postcondition(bool, string)
#1/srv/mediawiki/php-1.44.0-wmf.18/extensions/DiscussionTools/includes/Hooks/DataUpdatesHooks.php(48)MediaWiki\Extension\DiscussionTools\Hooks\HookUtils::parseRevisionParsoidHtml(MediaWiki\Revision\RevisionStoreRecord, string)
#2/srv/mediawiki/php-1.44.0-wmf.18/includes/deferred/MWCallableUpdate.php(52)MediaWiki\Extension\DiscussionTools\Hooks\DataUpdatesHooks->MediaWiki\Extension\DiscussionTools\Hooks\{closure}(string)
#3/srv/mediawiki/php-1.44.0-wmf.18/includes/deferred/DeferredUpdates.php(459)MediaWiki\Deferred\MWCallableUpdate->doUpdate()
#4/srv/mediawiki/php-1.44.0-wmf.18/includes/deferred/RefreshSecondaryDataUpdate.php(112)MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\MWCallableUpdate)
#5/srv/mediawiki/php-1.44.0-wmf.18/includes/deferred/DeferredUpdates.php(459)MediaWiki\Deferred\RefreshSecondaryDataUpdate->doUpdate()
#6/srv/mediawiki/php-1.44.0-wmf.18/includes/Storage/DerivedPageDataUpdater.php(1856)MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\RefreshSecondaryDataUpdate)
#7/srv/mediawiki/php-1.44.0-wmf.18/includes/page/WikiPage.php(1878)MediaWiki\Storage\DerivedPageDataUpdater->doSecondaryDataUpdates(array)
#8/srv/mediawiki/php-1.44.0-wmf.18/includes/jobqueue/jobs/RefreshLinksJob.php(298)WikiPage->doSecondaryDataUpdates(array)
#9/srv/mediawiki/php-1.44.0-wmf.18/includes/jobqueue/jobs/RefreshLinksJob.php(208)RefreshLinksJob->runForTitle(MediaWiki\Title\Title)
#10/srv/mediawiki/php-1.44.0-wmf.18/extensions/EventBus/includes/JobExecutor.php(80)RefreshLinksJob->run()
#11/srv/mediawiki/rpc/RunSingleJob.php(60)MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#12{main}
Impact
Notes
matmarex mentioned this in T390108: Comment inexplicably not in DiscussionTools database.Mar 26 2025, 10:05 PM
gerritbot added a comment.Mar 28 2025, 10:02 AM

Change #1131942 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Add more details to "Revision had no page" error

https://gerrit.wikimedia.org/r/1131942

gerritbot added a project: Patch-For-Review.Mar 28 2025, 10:02 AM
gerritbot added a comment.Apr 2 2025, 7:25 PM

Change #1131942 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add more details to "Revision had no page" error

https://gerrit.wikimedia.org/r/1131942

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2025, 7:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 2 2025, 9:00 PM
matmarex added a comment.Apr 7 2025, 11:53 PM

Once the above patch goes live, these errors will be logged as "PageRecord for page {page} revision {revision} not found", and will include the affected page/revision IDs so that we can find out what is happening with them.

matmarex renamed this task from PostconditionException: "Postcondition failed: Revision had no page" (in DiscussionTools) to "Postcondition failed: Revision had no page" / "PageRecord for page {page} revision {revision} not found" (in DiscussionTools).Apr 7 2025, 11:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits