EventBus: Error: Call to a member function isCurrent() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	Nov 17 2022, 4:51 PM

Description

Error

mwversion: 1.40.0-wmf.8
reqId: dbbeb562-01da-42c3-8b47-c58e31eee248
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Call to a member function isCurrent() on null

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.8/extensions/EventBus/includes/HookHandlers/MediaWiki/PageChangeHooks.php(374)
#0 /srv/mediawiki/php-1.40.0-wmf.8/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\EventBus\HookHandlers\MediaWiki\PageChangeHooks->onArticleRevisionVisibilitySet(Title, array, array)
#1 /srv/mediawiki/php-1.40.0-wmf.8/includes/HookContainer/HookRunner.php(820): MediaWiki\HookContainer\HookContainer->run(string, array)
#2 /srv/mediawiki/php-1.40.0-wmf.8/includes/revisiondelete/RevDelRevisionList.php(247): MediaWiki\HookContainer\HookRunner->onArticleRevisionVisibilitySet(Title, array, array)
#3 /srv/mediawiki/php-1.40.0-wmf.8/includes/revisiondelete/RevDelList.php(304): RevDelRevisionList->doPostCommitUpdates(array)
#4 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/MWCallableUpdate.php(38): RevDelList->{closure}()
#5 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(474): MWCallableUpdate->doUpdate()
#6 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(399): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#7 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(214): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, MediaWiki\JobQueue\JobQueueGroupFactory, string)
#8 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#9 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#10 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(235): DeferredUpdatesScope->processUpdates(integer, Closure)
#11 /srv/mediawiki/php-1.40.0-wmf.8/includes/MediaWiki.php(680): DeferredUpdates::doUpdates(NULL, integer)
#12 /srv/mediawiki/php-1.40.0-wmf.8/includes/MediaWiki.php(641): MediaWiki::preOutputCommit(RequestContext)
#13 /srv/mediawiki/php-1.40.0-wmf.8/includes/MediaWiki.php(918): MediaWiki->doPreOutputCommit()
#14 /srv/mediawiki/php-1.40.0-wmf.8/includes/MediaWiki.php(563): MediaWiki->main()
#15 /srv/mediawiki/php-1.40.0-wmf.8/index.php(50): MediaWiki->run()
#16 /srv/mediawiki/php-1.40.0-wmf.8/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}

Impact

Notes

Noted a few of these in recent logs for 1.40.0-wmf.8. Around 100 in last 2 weeks.

Details

Request URL: https://fr.wikipedia.org/w/index.php?action=submit&title=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	PageChangeHooks - Guard against null revision	mediawiki/extensions/EventBus	master	+21 -3

Customize query in gerrit

Event Timeline

brennen created this task.Nov 17 2022, 4:51 PM

Restricted Application added a project: Data-Engineering. · View Herald TranscriptNov 17 2022, 4:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

brennen added a project: User-brennen.Nov 17 2022, 4:52 PM

Krinkle moved this task from Untriaged to Nov 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:54 PM

Ottomata subscribed.Nov 17 2022, 7:05 PM

Interesting! I see there are some checks in the older EventBusHooks that guard against this. Will add the same ones in PageChangeHooks now.

Change 858405 had a related patch set uploaded (by Ottomata; author: Ottomata):

[mediawiki/extensions/EventBus@master] PageChangeHooks - Guard against null revision

https://gerrit.wikimedia.org/r/858405

gerritbot added a project: Patch-For-Review.Nov 17 2022, 7:17 PM

Change 858405 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] PageChangeHooks - Guard against null revision

https://gerrit.wikimedia.org/r/858405

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2022, 11:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 18 2022, 12:00 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Nov 18 2022, 10:21 PM

• EChetty edited projects, added Data-Engineering-Planning; removed Data-Engineering.Dec 1 2022, 2:12 PM

Ottomata closed this task as Resolved.Dec 13 2022, 8:15 PM

Ottomata claimed this task.

EventBus: Error: Call to a member function isCurrent() on nullClosed, ResolvedPublicPRODUCTION ERRORActions