unnecessary button on mobile talk pages
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Edu
	Nov 18 2022, 12:11 AM

Description

Steps to replicate the issue (include links if applicable):

go to a talk page on mobile version (example)

What happens?:
The message "Learn more about this page" appears at the top of the page. When I click the button, nothing happens.

What should have happened instead?:
The button was not there previously.

Other information (browser name/version, screenshots, etc.):

snapshot_en.m.wikipedia.org_1668729661898.png (696×540 px, 46 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't add lede button if mobile DiscussionTools not enabled	mediawiki/extensions/DiscussionTools	wmf/1.40.0-wmf.10	+2 -0
	Don't add lede button if mobile DiscussionTools not enabled	mediawiki/extensions/DiscussionTools	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned Here: T323241: "Learn more about this page" button always appears when the page has a table of contents in mobile DiscussionTools

Event Timeline

Edu created this task.Nov 18 2022, 12:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2022, 12:11 AM

Is this the same as T323241: "Learn more about this page" button always appears when the page has a table of contents in mobile DiscussionTools?

@Whatamidoing-WMF I think so. This is affecting multiple pages, not just talk pages. See the MediaWiki home page

matmarex added a project: DiscussionTools.Nov 18 2022, 2:33 PM

matmarex added a project: Editing-team (Kanban Board).Nov 18 2022, 2:40 PM

Change 858608 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Don't add lede button if mobile DiscussionTools not enabled

https://gerrit.wikimedia.org/r/858608

gerritbot added a project: Patch-For-Review.Nov 18 2022, 2:41 PM

matmarex claimed this task.Nov 18 2022, 2:41 PM

matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

Ladsgroup subscribed.Nov 18 2022, 3:06 PM

Change 858608 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Don't add lede button if mobile DiscussionTools not enabled

https://gerrit.wikimedia.org/r/858608

Change 858320 had a related patch set uploaded (by Ladsgroup; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.10] Don't add lede button if mobile DiscussionTools not enabled

https://gerrit.wikimedia.org/r/858320

Change 858320 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.10] Don't add lede button if mobile DiscussionTools not enabled

https://gerrit.wikimedia.org/r/858320

Mentioned in SAL (#wikimedia-operations) [2022-11-18T15:33:54Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:858320|Don't add lede button if mobile DiscussionTools not enabled (T323341)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-18T15:34:20Z] <ladsgroup@deploy1002> ladsgroup and ladsgroup: Backport for [[gerrit:858320|Don't add lede button if mobile DiscussionTools not enabled (T323341)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-18T15:42:42Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:858320|Don't add lede button if mobile DiscussionTools not enabled (T323341)]] (duration: 08m 47s)