Page MenuHomePhabricator
Create Task
Maniphest T323343

[1][2][3] style references in unusual vertical position when editing, and erroneous [0] references added when saving
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • All references are not superscripts. That is, they are aligned towards the bottom of the line instead of the top. (The exact appearance differs between sites due to site styles, on en.wp they look almost like subscripts.) Observe [1][2][3][4] and [5] in this screenshot:

image.png (529×1 px, 78 KB)

  • If you leave the editor (e.g. click "Read" or save the edit), each [1] style citation generates a corresponding [0] citation next to it.

image.png (525×1 px, 82 KB)

What should have happened instead?:

  • Normal editing and saving

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Undo use of .reference instead of .mw-ref in CSS counter rulesmediawiki/extensions/Citewmf/1.40.0-wmf.10+19 -19
VE: Use <sup> instead of <span> in CE HTMLmediawiki/extensions/Citewmf/1.40.0-wmf.10+1 -1
Undo use of .reference instead of .mw-ref in CSS counter rulesmediawiki/extensions/Citemaster+19 -19
VE: Use <sup> instead of <span> in CE HTMLmediawiki/extensions/Citemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Nov 18 2022, 12:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2022, 12:35 AM
matmarex added subscribers: ssastry, Arlolra, matmarex.Nov 18 2022, 11:49 AM

Caused by rECITd6705eb3f843: Parsoid CSS: Migrate to using .reference instead of .mw-ref (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/848555)

matmarex added a project: Cite.Nov 18 2022, 12:04 PM
matmarex updated the task description. (Show Details)
matmarex updated the task description. (Show Details)Nov 18 2022, 12:13 PM
gerritbot added a comment.Nov 18 2022, 12:14 PM

Change 858564 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Cite@master] VE: Use <sup> instead of <span> in CE HTML

https://gerrit.wikimedia.org/r/858564

gerritbot added a project: Patch-For-Review.Nov 18 2022, 12:14 PM
matmarex added a comment.Nov 18 2022, 12:14 PM

My patch fixes only the first problem.

The second problem seems trickier; the Parsoid CSS seems to be incompatible with the old parser HTML, and I don't see a good way to fix it. We might have to revert the change, I'm not sure if this can be done easily though since other work now depends on that.

Iniquity merged a task: T323352: Strange [0] citation shown after correct [n] citation.Nov 18 2022, 12:28 PM
Iniquity added a project: Regression.
Iniquity added subscribers: Xiplus, Wellverywell, Iniquity and 2 others.
Iniquity added a comment.Nov 18 2022, 12:41 PM

It seems to me that it is necessary to increase the priority.

IKhitron subscribed.Nov 18 2022, 12:47 PM
Iniquity merged a task: T323371: Duplicate references counter [0] after VisualEditor edit.Nov 18 2022, 1:08 PM
Iniquity added a subscriber: Nux.
gerritbot added a comment.Nov 18 2022, 1:47 PM

Change 858591 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Cite@master] Undo use of .reference instead of .mw-ref in Parsoid styles

https://gerrit.wikimedia.org/r/858591

PeterBowman subscribed.Nov 18 2022, 3:50 PM
gerritbot added a comment.Nov 18 2022, 4:42 PM

Change 858564 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Use <sup> instead of <span> in CE HTML

https://gerrit.wikimedia.org/r/858564

gerritbot added a comment.Nov 18 2022, 4:42 PM

Change 858591 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Undo use of .reference instead of .mw-ref in CSS counter rules

https://gerrit.wikimedia.org/r/858591

• ppelberg subscribed.Nov 18 2022, 4:48 PM
gerritbot added a comment.Nov 18 2022, 4:49 PM

Change 858321 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Cite@wmf/1.40.0-wmf.10] VE: Use <sup> instead of <span> in CE HTML

https://gerrit.wikimedia.org/r/858321

gerritbot added a comment.Nov 18 2022, 4:49 PM

Change 858322 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Cite@wmf/1.40.0-wmf.10] Undo use of .reference instead of .mw-ref in CSS counter rules

https://gerrit.wikimedia.org/r/858322

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 18 2022, 5:00 PM
gerritbot added a comment.Nov 18 2022, 5:13 PM

Change 858321 merged by jenkins-bot:

[mediawiki/extensions/Cite@wmf/1.40.0-wmf.10] VE: Use <sup> instead of <span> in CE HTML

https://gerrit.wikimedia.org/r/858321

gerritbot added a comment.Nov 18 2022, 5:13 PM

Change 858322 merged by jenkins-bot:

[mediawiki/extensions/Cite@wmf/1.40.0-wmf.10] Undo use of .reference instead of .mw-ref in CSS counter rules

https://gerrit.wikimedia.org/r/858322

Stashbot added a comment.Nov 18 2022, 5:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-18T17:13:33Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:858321|VE: Use <sup> instead of <span> in CE HTML (T323343)]], [[gerrit:858322|Undo use of .reference instead of .mw-ref in CSS counter rules (T323343)]]

Stashbot added a comment.Nov 18 2022, 5:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-18T17:13:53Z] <thcipriani@deploy1002> thcipriani and matmarex: Backport for [[gerrit:858321|VE: Use <sup> instead of <span> in CE HTML (T323343)]], [[gerrit:858322|Undo use of .reference instead of .mw-ref in CSS counter rules (T323343)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Stashbot added a comment.Nov 18 2022, 5:19 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-18T17:19:31Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:858321|VE: Use <sup> instead of <span> in CE HTML (T323343)]], [[gerrit:858322|Undo use of .reference instead of .mw-ref in CSS counter rules (T323343)]] (duration: 05m 58s)

matmarex added a comment.Nov 18 2022, 5:24 PM

The problem should be fixed on all wikis now.

matmarex claimed this task.Nov 18 2022, 5:24 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 18 2022, 6:00 PM
Novem_Linguae added a comment.Nov 18 2022, 6:45 PM

Appears fixed. The steps to reproduce no longer generates either error. Thanks for the quick patches and backport.

TrangaBellam closed this task as Resolved.Nov 19 2022, 10:49 AM
isaacl subscribed.Nov 20 2022, 4:06 AM
isaacl unsubscribed.Nov 20 2022, 5:12 PM
Stang unsubscribed.Nov 23 2022, 10:33 PM
Ericliu1912 unsubscribed.Nov 30 2022, 2:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL