Page MenuHomePhabricator

LeaveDialog: redirect from function editor
Closed, ResolvedPublic

Description

Description

When clicking the cancel button on the function editor, and clicking "discard edits" in the leave editor popup, the user should be re-directed back to the function viewer.

Devices and Design (URLs or screenshots)

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Event Timeline

@JKieserman this appears to be the current behavior. Please could you check on your end, and confirm if it is/isn't behaving as such?

@Ddwaal-WMF I propose more detailed steps to reproduce:

  1. Go to this function: https://wikifunctions.beta.wmflabs.org/wiki/Z10018
  2. Edit the function
  3. Change the content of the name field (DO NOT PUBLISH)
  4. Click on the Cancel button

    → You get a popup with this message: "If you leave without publishing first, you will lose your edits."

I am not sure whether a confirmation popup should appear. If it should, probably the text can be improved and customized to fit with the "Cancel" action.

Hey @Ddwaal-WMF , you are correct, it looks like this is working now. It must have been fixed as part of another patch.

@Teleosteen I see that too...I think that's actually good behavior here as a reminder to the user.

I propose we are good to close this ticket!

The scenario I described felt like a bit odd to me, but I cannot speak for everyone.
And as moreover I am not a UX expert, I am fine with closing the ticket :)

Ddwaal closed this task as Resolved.EditedDec 1 2022, 7:21 PM
Ddwaal claimed this task.

Thank you all for the input! I am going to go ahead and mark this ticket as resolved.