🎬️ desktop-de-13 | Reintroduce red border banner | ⏰ Nov 21st
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	kai.nissen
	Nov 18 2022, 3:46 PM

Description

Test Scope
We want to test the effect of reintroducing the red border banner.

Acceptance Criteria

The banners are based on the variant banner of desktop-de-12.
The control and variant banner have the same height.
The variant banner
- uses the design of desktop-wpde-01 or ipad-en-01.
- keeps the radio button form instead of the flat button form of above reference banners.
- supports the multi-step form of desktop-wpde-01-var.
- supports the soft-close feature of ipad-en-01-var.
Screenshots are created and uploaded to Shutterbug.

Banner Preview
control banner
variant banner

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T323385 🎬️ desktop-de-13 \| Campaign setup \| ⏰ Nov 21st
		Resolved		None	T323386 🎬️ desktop-de-13 \| Reintroduce red border banner \| ⏰ Nov 21st

Event Timeline

kai.nissen created this task.Nov 18 2022, 3:46 PM

kai.nissen updated the task description. (Show Details)

kai.nissen moved this task from Backlog to Ready for Work on the WMDE-FUN-Funban-2022 board.Nov 18 2022, 4:08 PM

Maintenance_bot added a project: WMDE-FUN-Team.Nov 18 2022, 4:30 PM

AbbanWMDE moved this task from Ready for Work to In Progress / Deployment (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.Nov 19 2022, 6:32 AM

AbbanWMDE moved this task from In Progress / Deployment (max. 4 tasks) to Acceptance Testing (Banners) on the WMDE-FUN-Funban-2022 board.Nov 19 2022, 9:38 AM

One tiny thing that has probably been around a while:
When using the custom amount field, the amount is displayed with decimal places. This is fine, but makes the headline on the 2nd form page get overlapped by the close button. We should limit the width of the headline to prevent that.

kai.nissen moved this task from Acceptance Testing (Banners) to Ready for Work on the WMDE-FUN-Funban-2022 board.Nov 21 2022, 10:54 AM

CorinnaHillebrand_WMDE claimed this task.Nov 21 2022, 11:55 AM

CorinnaHillebrand_WMDE moved this task from Ready for Work to In Progress / Deployment (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.

I added some padding for the title in this commit: https://github.com/wmde/fundraising-banners/pull/1129/commits/b2b249b639dd7e4aad70f20f8ae48e9c7af05b46,
couldn't observe any overlapping behaviour on my machine (firefox) though.

I redeployed the test13 banners to Central Notice with that fix.

CorinnaHillebrand_WMDE removed CorinnaHillebrand_WMDE as the assignee of this task.Nov 21 2022, 12:50 PM

CorinnaHillebrand_WMDE moved this task from In Progress / Deployment (max. 4 tasks) to Acceptance Testing (Banners) on the WMDE-FUN-Funban-2022 board.

CorinnaHillebrand_WMDE added a subscriber: CorinnaHillebrand_WMDE.

kai.nissen moved this task from Acceptance Testing (Banners) to Code Review (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.Nov 21 2022, 2:13 PM

CorinnaHillebrand_WMDE moved this task from Code Review (max. 4 tasks) to Done on the WMDE-FUN-Funban-2022 board.Nov 22 2022, 2:49 PM

kai.nissen mentioned this in W2044 Welcome.Dec 5 2022, 12:09 PM

kai.nissen closed this task as Resolved.Jan 4 2023, 1:10 PM