Page MenuHomePhabricator
Create Task
Maniphest T323393

🎬️ mobile-de-10 | Remind me later | ⏰ Nov 22nd
Closed, ResolvedPublic
Actions

Description

Test Scope
We want to test the effect of introducing the "Remind me later" feature on mobile banners (see design file).

Acceptance Criteria

  • The banners are based on the variant banner of mobile-de-09.
  • The variant banner shows a link below the submit button in both the mini banner and the expanded banner ("Erinnerung per E-Mail").
  • Clicking on the link displays the overlay.
  • When the validation fails on submit, error messages are displayed below the respective field.

Notes

  • Mini banner and overlay form might be too large on small devices, especially in landscape mode. Since the mini banner is not scrollable, we need to make sure that it fits screens by
    • not strictly displaying the overlay below the banner and/or
    • giving it more width.

Banner Preview
control banner
variant banner

Related Objects
Search...

Event Timeline

kai.nissen created this task.Nov 18 2022, 4:26 PM
Maintenance_bot added a project: WMDE-FUN-Team.Nov 18 2022, 4:30 PM
kai.nissen moved this task from Backlog to Ready for Work on the WMDE-FUN-Funban-2022 board.Nov 21 2022, 10:10 AM
CorinnaHillebrand_WMDE claimed this task.Nov 21 2022, 12:51 PM
CorinnaHillebrand_WMDE moved this task from Ready for Work to In Progress / Deployment (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.
CorinnaHillebrand_WMDE removed CorinnaHillebrand_WMDE as the assignee of this task.Nov 21 2022, 1:14 PM
CorinnaHillebrand_WMDE moved this task from In Progress / Deployment (max. 4 tasks) to Blocked Externally/On Hold on the WMDE-FUN-Funban-2022 board.
CorinnaHillebrand_WMDE subscribed.

needs Ctrl / Var decision

tmletzko subscribed.Nov 21 2022, 1:16 PM

please use #9 var @CorinnaHillebrand_WMDE

tmletzko updated the task description. (Show Details)Nov 21 2022, 1:17 PM
CorinnaHillebrand_WMDE claimed this task.Nov 21 2022, 1:21 PM
CorinnaHillebrand_WMDE moved this task from Blocked Externally/On Hold to In Progress / Deployment (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.
gabriel-wmde removed CorinnaHillebrand_WMDE as the assignee of this task.Nov 21 2022, 5:51 PM
gabriel-wmde moved this task from In Progress / Deployment (max. 4 tasks) to Acceptance Testing (Banners) on the WMDE-FUN-Funban-2022 board.
kai.nissen added a comment.Nov 22 2022, 1:56 PM

@CorinnaHillebrand_WMDE Didn't cross my mind when writing the task description: Introducing that to the mini banner increases the height. The height of the control banner should be increased by the same amount. Probably best to add some space before the button at the bottom. Apart from that, the banners look good to go.

kai.nissen moved this task from Acceptance Testing (Banners) to Ready for Work on the WMDE-FUN-Funban-2022 board.Nov 22 2022, 3:03 PM
kai.nissen added a comment.Nov 22 2022, 3:53 PM

Ugh, there are some more issues with the banners:

  • The banners are using outdated use of funds content.
  • The highlighted sentence is not correct in the expanded banner. Instead of "Millionen Menschen nutzen Wikipedia, aber 99 % spenden nicht – sie übergehen diesen Aufruf." it should say "Über 6 Millionen Mal wird unser Spendenaufruf täglich angezeigt, aber nur 150.865 Menschen haben bisher gespendet." (visitorsVsDonorsSentence)
CorinnaHillebrand_WMDE moved this task from Ready for Work to In Progress / Deployment (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.Nov 22 2022, 4:18 PM
kai.nissen moved this task from In Progress / Deployment (max. 4 tasks) to Code Review (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.Nov 22 2022, 4:35 PM
CorinnaHillebrand_WMDE moved this task from Code Review (max. 4 tasks) to Done on the WMDE-FUN-Funban-2022 board.Nov 26 2022, 11:47 AM
kai.nissen closed this task as Resolved.Jan 4 2023, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL