| Novem_Linguae | |
| Nov 18 2022, 10:33 PM |
| F35796194: image.png | |
| Nov 18 2022, 10:33 PM |
I assume these...
private static function shouldNoIndexForNewArticleReasons( WikiPage $page ) {
global $wgPageTriageNoIndexUnreviewedNewArticles, $wgPageTriageMaxAge;
Should be changed to something like...
$config = MediaWikiServices::getInstance()->getMainConfig(); $pageTriageDraftNamespaceId = $config->get( 'PageTriageDraftNamespaceId' );
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| [Cleanup] Avoid the usage of globals and use MainConfig object | D3r1ck01 | mediawiki/extensions/PageTriage | master | +6 -7 |
@Novem_Linguae yeah that would be good. Even better would be to pass Config $config to the static method (or pass e.g. int $PageTriageMaxAge). Ideally the method is passed whatever it needs to do its work, rather than "reaching outside" (e.g. invoke the service to get the config object); that tends to help with readability & makes testing easier as well.
Change #1329330 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):
[mediawiki/extensions/PageTriage@master] [Cleanup] Avoid the usage of globals and use MainConfig object
Change #1329330 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] [Cleanup] Avoid the usage of globals and use MainConfig object