Page MenuHomePhabricator

NewImpact: graph does not show the dips and peaks that correspond to the page views
Closed, ResolvedPublic

Description

From T220141#8401627:

  1. The graph does not show the dips and peaks that correspond to the page views, as designed in Figma. It is pretty much on the same level all through, whereas the page view count go as low as 4000 and as high as 10,000.
image.png (226×604 px, 25 KB)
image.png (358×1 px, 52 KB)

Acceptance Criteria

  1. Should be able to see same peaks/dips in impact module graphs as on the page views tool
  2. ....
Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

Change 860942 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] User impact trendcharts: use space better

https://gerrit.wikimedia.org/r/860942

Change 860942 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact trendcharts: use space better

https://gerrit.wikimedia.org/r/860942

Change 860942 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact trendcharts: use space better

https://gerrit.wikimedia.org/r/860942

@Tgr the above might have introduced (or surfaced) another issue, which is that the start time in the sparkline doesn't seem to match what the page views tool shows. Compare:

image.png (540×780 px, 86 KB)

image.png (1×2 px, 1 MB)

Per the page views tool, I'd expect:

  • to see the spike all the way to the left in the sparkline in the articles list
  • the page view count in the articles list (8,568) to match what the page views tool shows (7,835)

Definitely not introduced, the patch just changed the vertical spacing. I think this is T323253: NewImpact module: Page view data should be limited to when user made their first edit: the pageview tool shows the time range from the user's first edit to the present day, the sparklines show the last 60 days, with days before the user's first edit zeroed out. Which makes sense IMO, it would be very confusing to show a bunch of sparklines under each other in a table column, with the x axis having a different meaning for each. Probably the nice approach would be to cut the entire chart at the first edit date, and just have the rest be empty space (or maybe keep the chart but cut the line).

Etonkovidova closed this task as Resolved.EditedFeb 7 2023, 11:07 PM
Etonkovidova subscribed.

Checked in wmf.21

Screen Shot 2023-02-07 at 2.58.33 PM.png (988×1 px, 196 KB)

@Tgr - still there are the cases where it's difficult to make a visual connection between the spakline and the pageview stats, e.g.

the first article (with{ 111,245 views)
Screen Shot 2023-02-07 at 3.24.42 PM.png (522×1 px, 76 KB)
the pageviews
Screen Shot 2023-02-07 at 3.27.06 PM.png (759×1 px, 575 KB)