Page MenuHomePhabricator
Create Task
Maniphest T323552

Remove deprecated jquery.ui from PageTriage
Open, Needs TriagePublic
Actions

Description

  • replace .button() in 39 spots
  • replace .draggable() in 1 spot
  • turn off jquery.ui in PageTriage in a localhost environment and see if anything else breaks. identify and fix breakages

Motivation: jquery.ui is maintained upstream, but MediaWiki has marked it as deprecated since 2017 because they want to reduce the amount of libraries/bandwidth being loaded on the front end

Converting PageTriage to Codex (T208256) is a big project that would probably change the front end a lot, so may not have consensus and the work may not happen. So this ticket is an intermediate step. If there's a way to get rid of jquery.ui without changing the front end appearance of PageTriage significantly and without creating a lot of work, we should move forward with that. Perhaps we can use a .button() from one of our supported libraries.

Related Objects
Search...

Event Timeline

Novem_Linguae created this task.Nov 22 2022, 8:57 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 22 2022, 8:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.Nov 22 2022, 8:57 AM
Novem_Linguae added a parent task: T49145: Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core.
Novem_Linguae mentioned this in T49145: Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core.
kostajh awarded a token.Nov 22 2022, 9:03 AM
kostajh added a project: Technical-Debt.Nov 23 2022, 10:30 AM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.
HouseBlaster moved this task from Unsorted to Needs removal on the Technical-Debt board.Dec 11 2022, 10:10 PM
Jdlrobson subscribed.Mar 31 2023, 8:07 PM
Jdlrobson added a project: WikiLove.Apr 5 2023, 11:05 PM

Note that removing jquery.ui from Pagetriage will not remove jquery.ui from page load since WikiLove also uses it and is closely coupled with the code here.

HideonRosie subscribed.Apr 8 2023, 2:43 AM
Aklapper removed a project: PageTriage.Oct 17 2023, 9:06 PM
Aklapper edited projects, added PageTriage; removed Growth-Team.Oct 17 2023, 9:11 PM
jsn.sherman subscribed.Wed, Apr 17, 3:23 PM

I wanted to note that the new toolbar ui (currently behind the pagetriage_tb url parameter) replaces draggable() already. You can access it by following review links from the feed with the parameter set: https://en.wikipedia.org/wiki/Special:NewPagesFeed?pagetriage_tb=new. It's a partial vue migration that should work as a drop in replacement for the current one.
see T340117 for more info

I would suggest that we could go ahead and promote the new toolbar as it is and then remove the old toolbar if everyone is happy with it. Migration of individual buttons could then be handled behind their own url parameters as they get done over time.

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptWed, Apr 17, 3:23 PM
Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Tue, Apr 23, 12:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL