Page MenuHomePhabricator
Create Task
Maniphest T323560

Article titles in the article list and contributions link should always be blue
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Article link scenario

  1. Navigate to Special:Homepage
  2. Visit one of the articles in the list in the user impact module
  3. Navigate back to Special:Homepage

Contributions link scenario

  1. Navigate to Special:Homepage
  2. Visit the Special:Contributions module bottom link
  3. Navigate back to Special:Homepage

What happens?:
The link shows in black or as visited.

What should have happened instead?:
The link shows in blue (not visited).

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
User impact: always display contributions link as not visitedmediawiki/extensions/GrowthExperimentsmaster+5 -1
User impact: always display article links in bluemediawiki/extensions/GrowthExperimentsmaster+5 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sgs created this task.Nov 22 2022, 11:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2022, 11:08 AM
gerritbot added a comment.Nov 22 2022, 11:14 AM

Change 859460 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: always display article links in blue

https://gerrit.wikimedia.org/r/859460

gerritbot added a project: Patch-For-Review.Nov 22 2022, 11:14 AM
Sgs claimed this task.Nov 22 2022, 11:16 AM
Sgs moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs updated the task description. (Show Details)
kostajh added a subscriber: RHo.Nov 23 2022, 9:13 AM

@RHo The "View all your edits" link still has the purple visited style, should we change that to blue as well?

image.png (1×804 px, 143 KB)

gerritbot added a comment.Nov 23 2022, 9:30 AM

Change 859460 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: always display article links in blue

https://gerrit.wikimedia.org/r/859460

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 23 2022, 10:01 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 23 2022, 10:30 AM
RHo added a comment.Nov 23 2022, 11:44 AM
In T323560#8416129, @kostajh wrote:

@RHo The "View all your edits" link still has the purple visited style, should we change that to blue as well?

image.png (1×804 px, 143 KB)

Hi @kostajh @Sgs - yes please, that makes sense since (TIL) OOUI doesn't apply an a:visited link style.

gerritbot added a comment.Nov 23 2022, 11:46 AM

Change 860008 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: always display contributions link as not visited

https://gerrit.wikimedia.org/r/860008

gerritbot added a project: Patch-For-Review.Nov 23 2022, 11:46 AM
Sgs renamed this task from Article titles in the article list should always be blue to Article titles in the article list and contributions link should always be blue.Nov 23 2022, 12:31 PM
Sgs updated the task description. (Show Details)
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 23 2022, 12:42 PM
gerritbot added a comment.Nov 23 2022, 1:00 PM

Change 860008 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: always display contributions link as not visited

https://gerrit.wikimedia.org/r/860008

Maintenance_bot removed a project: Patch-For-Review.Nov 23 2022, 1:30 PM
• EUdoh-WMF subscribed.Nov 23 2022, 11:01 PM

Hi @Sgs, I still see the black link in Safari v16 after viewing an article.

image.png (1×1 px, 299 KB)

kostajh added a comment.Nov 25 2022, 2:38 PM
In T323560#8418822, @EUdoh-WMF wrote:

Hi @Sgs, I still see the black link in Safari v16 after viewing an article.

image.png (1×1 px, 299 KB)

hmm, I can't reproduce that in Safari. Could you please do a hard refresh or double-check that "Disable caches" in the Network tab is set, to be sure that you have the new version of the code?

image.png (816×2 px, 142 KB)

• EUdoh-WMF moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 29 2022, 10:47 PM

Hi @kostajh, I did a hard refresh and yes, I can no longer see the black link. Thanks!

Etonkovidova closed this task as Resolved.Dec 2 2022, 1:25 AM
Etonkovidova subscribed.

Verified in wmf.12 - all links stayed blue.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits