When publishing a new function, a browser confirmation dialog appears
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Teleosteen
	Nov 22 2022, 12:08 PM

Description

Steps to replicate the issue (include links if applicable):

(Using Firefox, not checked with other browsers)

Go to https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject?view=function-editor
Fill basic information so the function can be published
Click on the Publish button
The "Publish your change" in order to fill the summary appears, validate the publication

What happens?:

A browser dialog appears, which warns that we're about to leave the page:

2022-11-22_13-04.png (441×948 px, 47 KB)

What should have happened instead?:
The publication should be effective right after the first dialog.

Software version: cbf93482049715a41c827e08cf63ffbf30a56dd0

Other information: My browser is Firefox Nightly (109.0a1 (2022-11-21))

Event Timeline

Teleosteen created this task.Nov 22 2022, 12:08 PM

Seems like it is a side effect of this commit:

commit 3ac72623b138d3d9f4793344b87a7e752dc44ad2
Author: Dani de Waal <ddwaal-ctr@wikimedia.org>
Date:   Mon Nov 14 12:39:44 2022 -0500

    Add the default browser are you sure message when trying to reload the
    page on the function and zobject editor.

Should we somehow add exceptions when clicking on "publish" or "cancel" buttons so the browser confirmation dialog does not appear?

cc @Ddwaal-WMF

Teleosteen added a project: WikiLambda.Nov 22 2022, 4:47 PM

Jdforrester-WMF moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 22 2022, 7:38 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 22 2022, 7:44 PM

This was fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/858385.

We already have a custom "are you sure" dialog for clicks within the app, and as it seems you can't specify a "browser refresh" click, (and there are some browser compatibility issues), going to remove it altogether for now.

Ddwaal closed this task as Resolved.Nov 23 2022, 6:25 PM

Ddwaal claimed this task.

@Ddwaal-WMF Looks good. I wonder, on WikiData, when changing content and refreshing, the content is restored.

Cannot we do the same for WikiFunctions?

When publishing a new function, a browser confirmation dialog appearsClosed, ResolvedPublicBUG REPORTActions

Description

Event Timeline

When publishing a new function, a browser confirmation dialog appears
Closed, ResolvedPublicBUG REPORT
Actions