Page MenuHomePhabricator

NewImpact: Minimal loading state
Open, MediumPublic

Description

Based on T321675#8411188,

So I guess the question is if we should try to accommodate what is happening in phase 1, before the JS loads, or just do something ultra minimal like setting a minimum height on the impact module box?

My inclination is your suggested minimal approach and setting a min height based on height of the contents when using default english copy, which seems to be ~786px.

In this task, we want a minimal loading state, with a minimum height while the JS is loading.

Event Timeline

kostajh triaged this task as Medium priority.Tue, Nov 22, 1:23 PM
kostajh created this task.

Change 860566 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Add minimum height for mobile overlay summary

https://gerrit.wikimedia.org/r/860566

Change 860571 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Add minimum height for unactivated desktop

https://gerrit.wikimedia.org/r/860571

Change 860578 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Set minimum height for activated desktop module

https://gerrit.wikimedia.org/r/860578

Change 860566 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Set minimum height for mobile overlay summary

https://gerrit.wikimedia.org/r/860566

Change 860578 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Set minimum height for activated desktop module

https://gerrit.wikimedia.org/r/860578

Change 860571 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Set minimum height for unactivated desktop

https://gerrit.wikimedia.org/r/860571