Page MenuHomePhabricator

wgMaxRedirects > 1 not working as intended (redirects not updated after move?)
Open, LowPublic

Description

After a page move all redirects which a linking to the moved page have to be updated to the new target.

The problem is only visible with $wgMaxRedirects > 1, because than there a working redirects pointing to the page which are not updated after move and so the redirection is not working proper.

The update of the redirect table is missing.

Thanks.

Steps to reproduce:

  • set $wgMaxRedirects = 2;
  • create page A with text
  • move page A to page B with a redirect
  • move page B to page C with a redirect
  • visited page A, you get redirect to page B, not to page C
  • create page A2 with a redirect to page B (copy the wikitext from page A)
  • visited page A2, you get redirect to page C

Version: 1.20.x
Severity: normal

Details

Reference
bz30359

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:51 PM
bzimport set Reference to bz30359.
bzimport added a subscriber: Unknown Object (MLST).

This is one of the reasons why I thought allowing multiple redirects was a bad idea.

However, we should NOT update the redirect table such that A->C, because that will break things if B is edited to be a redirect to D. Instead, the redirect table should continue saying A->B and B->C, and the redirect resolution code should follow both redirects rather than stopping after the first one.

  • Bug 33520 has been marked as a duplicate of this bug. ***

Was wondering - when double redirects are allowed, will there also be "triple redirects", "quadruple redirects" and so on? And will they also be allowed and functional?

Was wondering - when double redirects are allowed, will there also be "triple redirects", "quadruple redirects" and so on? And will they also be allowed and functional?

It depends just on the $wgMaxRedirects setting for the given wikisite. If it is set to 4, then a chain A->B->C->D->E will be transparent to the reader, but upon visiting A for the chain A->B->C->D->E->F you will see

E

(Redirected from A)
→F

This task cannot be a duplicate of T67064, because the bug described here is not mentioned there.

Krinkle renamed this task from redirects to a page not updated after move to wgMaxRedirects > 1 not working as intended (redirects not updated after move?).Apr 30 2017, 3:17 AM
Krinkle removed a project: Wikimedia-Site-requests.
Krinkle added subscribers: Se4598, Fomafix, Luke081515.
Krinkle removed a subscriber: wikibugs-l-list.

I guess this claim at T32359#1913500 was unexpected, if not, feel free to revert.