Clean up overflow tab logic
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	bwang
	Nov 22 2022, 4:48 PM

Description

Background

The Page Tools dropdown used to be the more menu, which acted as the overflow menu for items in the page toolbar on small resolutions. The more menu used to have to handle edge cases that arise from the fact that it could contain only hidden elements and that core's emptyPortlet class isn't well suited for this use case.

Now that the more menu dropdown is the Page Tools dropdown, which will always be present and have visible items, we can simplify/throw away a lot of this code

TODO

Review SkinVector22::mergeViewOverflowIntoActions
Review .vector-has-collapsible-items classes and CSS
Replace .vector-more-collapsible-item and user-links-collapsible-item with a generic collapsible item class

Event Timeline

bwang created this task.Nov 22 2022, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2022, 4:48 PM

Jdlrobson moved this task from Backlog to Vector code cleanup on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Nov 23 2022, 1:42 AM

Jdlrobson triaged this task as Medium priority.Mar 15 2023, 10:31 PM

bwang renamed this task from Simplify collapsible item logic in the Page Tools dropdown to Clean up overflow tab logic.Mar 17 2023, 4:07 PM

bwang added a parent task: T332090: Post page tools cleanup: Remove page tools disabled code.Mar 27 2023, 6:22 PM

Declined as it seems we cant simplify the cactions menu because there are still cases when it only contains elements that are hidden on larger screen sizes, hence the need to use emptyPortlet and add these extra CSS classes.

Clean up overflow tab logicClosed, DeclinedPublicActions

Description

Background

TODO

Event Timeline

Clean up overflow tab logic
Closed, DeclinedPublic
Actions