Page MenuHomePhabricator
Create Task
Maniphest T323627

Update favicon and CentralAuthLoginIcon for wikifunctionswiki
Closed, ResolvedPublic
Actions

Description

Currently the favicon for wikifunctions in static/favicon has only a 16*16 format of size:

koi@vm1:~/mediawiki-config/static/favicon$ identify wikifunctions.ico
wikifunctions.ico ICO 16x16 16x16+0+0 8-bit sRGB 1150B 0.000u 0:00.000
koi@vm1:~/mediawiki-config/static/favicon$ identify commons.ico
commons.ico[0] PNG 16x16 16x16+0+0 8-bit sRGB 528B 0.000u 0:00.000
commons.ico[1] PNG 32x32 32x32+0+0 8-bit sRGB 1260B 0.000u 0:00.000
commons.ico[2] PNG 48x48 48x48+0+0 8-bit sRGB 3865B 0.000u 0:00.000

Another issue is the sul logo of wikifunctions (on beta cluster). When viewing from Special:CentralLogin, the logo representing wikifunctions is missing.

image.png (371×1 px, 74 KB)

Details

SubjectRepoBranchLines +/-
Update favicon and CentralAuthLoginIcon for wikifunctionswikioperations/mediawiki-configmaster+3 -0
Update favicon and CentralAuthLoginIcon for wikifunctionswikioperations/mediawiki-configmaster+3 -0
Customize query in gerrit

Event Timeline

Stang created this task.Nov 22 2022, 4:58 PM
gerritbot added a comment.Nov 22 2022, 4:59 PM

Change 858717 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Update favicon and CentralAuthLoginIcon for wikifunctionswiki

https://gerrit.wikimedia.org/r/858717

gerritbot added a project: Patch-For-Review.Nov 22 2022, 4:59 PM
Jdforrester-WMF moved this task from To triage to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 22 2022, 7:38 PM
gerritbot added a comment.Nov 22 2022, 9:02 PM

Change 858717 merged by jenkins-bot:

[operations/mediawiki-config@master] Update favicon and CentralAuthLoginIcon for wikifunctionswiki

https://gerrit.wikimedia.org/r/858717

Stang added a comment.Nov 22 2022, 9:08 PM
In T323627#8415054, @gerritbot wrote:

Change 858717 merged by jenkins-bot:

[operations/mediawiki-config@master] Update favicon and CentralAuthLoginIcon for wikifunctionswiki

https://gerrit.wikimedia.org/r/858717

Not actually deployed, just looking for a +1; I'm not pretty sure what kind of logo to use for SUL icons, or we should use https://commons.wikimedia.org/wiki/File:Wikifunctions-logo.svg?

gerritbot added a comment.Nov 22 2022, 9:11 PM

Change 859510 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Revert "Revert "Update favicon and CentralAuthLoginIcon for wikifunctionswiki""

https://gerrit.wikimedia.org/r/859510

Reedy added a project: Wikimedia-Site-requests.Nov 22 2022, 11:33 PM
Jdforrester-WMF subscribed.Nov 23 2022, 2:23 PM
In T323627#8415080, @Stang wrote:
In T323627#8415054, @gerritbot wrote:

Change 858717 merged by jenkins-bot:

[operations/mediawiki-config@master] Update favicon and CentralAuthLoginIcon for wikifunctionswiki

https://gerrit.wikimedia.org/r/858717

Not actually deployed, just looking for a +1; I'm not pretty sure what kind of logo to use for SUL icons, or we should use https://commons.wikimedia.org/wiki/File:Wikifunctions-logo.svg?

That looks good to me. Please go ahead.

gerritbot added a comment.Nov 23 2022, 9:05 PM

Change 859510 merged by jenkins-bot:

[operations/mediawiki-config@master] Update favicon and CentralAuthLoginIcon for wikifunctionswiki

https://gerrit.wikimedia.org/r/859510

Stashbot added a comment.Nov 23 2022, 9:05 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-23T21:05:41Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:859510|Update favicon and CentralAuthLoginIcon for wikifunctionswiki (T323627)]]

Stashbot added a comment.Nov 23 2022, 9:10 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-23T21:10:28Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:859510|Update favicon and CentralAuthLoginIcon for wikifunctionswiki (T323627)]]

Stashbot added a comment.Nov 23 2022, 9:16 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-23T21:16:52Z] <cjming@deploy1002> sync-world aborted: Backport for [[gerrit:859510|Update favicon and CentralAuthLoginIcon for wikifunctionswiki (T323627)]] (duration: 06m 24s)

Stashbot added a comment.Nov 23 2022, 9:18 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-23T21:18:14Z] <brennen@deploy1002> Started scap: Backport for [[gerrit:859510|Update favicon and CentralAuthLoginIcon for wikifunctionswiki (T323627)]]

Stashbot added a comment.Nov 23 2022, 9:19 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-23T21:19:33Z] <brennen@deploy1002> brennen and stang: Backport for [[gerrit:859510|Update favicon and CentralAuthLoginIcon for wikifunctionswiki (T323627)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Nov 23 2022, 9:24 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-23T21:24:43Z] <brennen@deploy1002> Finished scap: Backport for [[gerrit:859510|Update favicon and CentralAuthLoginIcon for wikifunctionswiki (T323627)]] (duration: 06m 29s)

Maintenance_bot removed a project: Patch-For-Review.Nov 23 2022, 9:30 PM
Stang closed this task as Resolved.Nov 23 2022, 9:32 PM

image.png (230×1 px, 61 KB)

It works

Stang unsubscribed.Nov 26 2022, 10:33 PM
Jdforrester-WMF added a comment.Nov 28 2022, 4:05 PM

Thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL