Page MenuHomePhabricator

Function View: Names and aliases have disappeared from the function view page
Closed, ResolvedPublicBUG REPORT

Description

Description

In the function view page "About" tab there should be information of the name/labels/aliases of the function. These cannot be seen now.

Steps to reproduce:

  1. For a function without multilingual information (just one label in the main language), go to: https://wikifunctions.beta.wmflabs.org/wiki/Z10097
  2. For a function with multilingual information, go to: https://wikifunctions.beta.wmflabs.org/wiki/Z10014

Observed behavior:

  • Functions with no multilingual information, the whole name section is empty, only the sidebar is visible:

Screenshot from 2022-11-23 09-01-40.png (870×1 px, 87 KB)

  • Functions with multilingual information, when expanding the labels and aliases in other languages, only the language chip is visible but not the name:

Screenshot from 2022-11-23 09-01-49.png (879×1 px, 105 KB)

Expected behavior (Acceptance criteria):

  • All labels should be visible
  • If there's nothing to show in the main page we should probably show something, else it looks weird to have an empty "main" space with a crowded sidebar

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Event Timeline

Change 859554 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Add the alias name back in the function viewer sidebar. It seems it was accidentally removed in g/859532.

https://gerrit.wikimedia.org/r/859554

I have handled 2. It seems it was accidentally removed in a previous patch.

For 1, what would we prefer to show if there are no other languages/aliases to show, rather than the white space? @AAlhazwani-WMF @SWoodruff-WMF

Also, if there are tester examples they show in that space: {F35816641}

Change 859554 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add the alias name back in the function viewer sidebar. It seems it was accidentally removed in g/859532.

https://gerrit.wikimedia.org/r/859554

Change 859555 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Add a test for the chip + label being displayed for extra languages on the Function About tab.

https://gerrit.wikimedia.org/r/859555

In T323676#8418484, @Ddwaal-WMF wrote:

For 1, what would we prefer to show if there are no other languages/aliases to show, rather than the white space? @AAlhazwani-WMF @SWoodruff-WMF

@Ddwaal-WMF if there are no languages, or aliases, or testers available we could hide .ext-wikilambda-function-about__sidebar. Alternatively, we could potentially surface opportunities for contribution in this white space, but I would think about this later on.

image.png (1×2 px, 345 KB)

Change 861869 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Fix the aliases not showing on the Function Viewer.

https://gerrit.wikimedia.org/r/861869

Change 861869 abandoned by Dani DW:

[mediawiki/extensions/WikiLambda@master] Fix the aliases not showing on the Function Viewer.

Reason:

https://gerrit.wikimedia.org/r/861869

Change 860594 merged by EWright:

[mediawiki/extensions/WikiLambda@master] On Function Viewer: -Hide sidebar if no aliases, names in other languages, or tester examples exist. -Fix the alias chips not showing in the user lang.

https://gerrit.wikimedia.org/r/860594

Change 859555 abandoned by Dani DW:

[mediawiki/extensions/WikiLambda@master] Add a test for the chip + label being displayed for extra languages on the Function About tab.

Reason:

https://gerrit.wikimedia.org/r/859555