tester creation page from function definition page the Function Zid is not pre-selected
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

Authored By

	gengh
	Nov 23 2022, 9:29 AM

Description

Steps to reproduce:

For implementation: click on the link https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject?zid=Z14&Z14K1=Z10097
For tester: click on the link https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject?zid=Z20&Z20K1=Z10097

Observed behavior:

These links have the props Z14K1=Z10097 and Z20K1=Z10097 so that the field "function" in the create zobject page is pre-loaded
But the field is empty

Expected behavior (Acceptance criteria):

The function field in both pages should be preloaded with the function Z10097/Mushroom scientific name

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikiLambda	master	+12 -12	Implementation/Tester creation: When loading implementation/tester creation page from function definition page the Function Zid is not pre-selected.

Customize query in gerrit

Related Objects

Mentioned In: T323760: The test function page is hard to understand
Mentioned Here: T323381: FunctionViewerDetailsSidebar: CreateZObject page is loaded with implementation or tester but the associated function is not pre-populated

Event Timeline

gengh created this task.Nov 23 2022, 9:29 AM

gengh moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 23 2022, 9:34 AM

gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

gengh moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.

Teleosteen mentioned this in T323760: The test function page is hard to understand.Nov 24 2022, 11:03 AM

Teleosteen claimed this task.Nov 25 2022, 10:01 AM

@gengh Is this bug different from T323381?

DVrandecic moved this task from Ready: G5. Fallback view to Ready: G9. Cleanup after default component implementation on the Abstract Wikipedia team (Phase θ – Throttling) board.Dec 8 2022, 11:38 PM

Ddwaal claimed this task.Dec 9 2022, 10:22 PM

Ddwaal added a subscriber: Teleosteen.

Change 866460 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Implementation/Tester creation: When loading implementation/tester creation page from function definition page the Function Zid is not pre-selected.

https://gerrit.wikimedia.org/r/866460

gerritbot added a project: Patch-For-Review.Dec 9 2022, 10:25 PM

So sorry @Teleosteen , didn't see you had claimed this before I worked on it! I have a patch attached above, hope there wasn't double work done. Feel free to share if you had come up with something else, it might be cleaner than mine.. :) was a bit of a messy problem. If not, then I will add some tests to the above, or you may!

And to answer your question @Teleosteen, yes this is a duplicate of T323381

@Ddwaal-WMF Thanks for your answer. If you would like, I propose you therefore to you take a look at the patches I made in T323381.

This has been solved by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/861917

Change 866460 abandoned by Dani DW:

[mediawiki/extensions/WikiLambda@master] Implementation/Tester creation: When loading implementation/tester creation page from function definition page the Function Zid is not pre-selected.

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/861917 fixes the issue

https://gerrit.wikimedia.org/r/866460

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2022, 4:30 PM

Implementation/Tester creation: When loading implementation/tester creation page from function definition page the Function Zid is not pre-selectedOpen, Needs TriagePublicBUG REPORTActions

Description

Description

Completion checklist

Details

Related Objects

Event Timeline

Implementation/Tester creation: When loading implementation/tester creation page from function definition page the Function Zid is not pre-selected
Open, Needs TriagePublicBUG REPORT
Actions