Can you split this task and create one for each of the issues?
That would help both splitting the work and tracking the issues themselves.

I can help with that if you prefer but might bother you asking for details for each xd

In T323681#8416674, @dcaro wrote:

Can you split this task and create one for each of the issues?
That would help both splitting the work and tracking the issues themselves.

I'm not sure yet whether that would be actually helpful – I suspect most changes would be to _run_external_command(), which is ~10 lines. Having several people working on such as small area of code at the same time could be counterproductive. I may of course be wrong about this, so I'll tinker with it a little first, and if it makes sense, split it up into subtasks as you suggest.

In T323681#8416708, @Slst2020 wrote:

In T323681#8416674, @dcaro wrote:

Can you split this task and create one for each of the issues?
That would help both splitting the work and tracking the issues themselves.

I'm not sure yet whether that would be actually helpful – I suspect most changes would be to _run_external_command(), which is ~10 lines. Having several people working on such as small area of code at the same time could be counterproductive. I may of course be wrong about this, so I'll tinker with it a little first, and if it makes sense, split it up into subtasks as you suggest.

👍

Would it be okay to drop the addition of the --help option to all discovered subcommands, and just have the click command be a pass-through for all and any args and options? Or are we sure that all external commands will accept this flag, as opposed to using another of the commonly used ways to display help?:

• running the command with no options or args
• help
• -help

and just have the click command be a pass-through for all and any args and options?

Yep, that'd be ok, iirc the pass-through of the --help command was because click handles --help specially, but the goal was just to pass it through (--help, or whatever else).

In T323681#8417167, @dcaro wrote:

and just have the click command be a pass-through for all and any args and options?

Yep, that'd be ok, iirc the pass-through of the --help command was because click handles --help specially, but the goal was just to pass it through (--help, or whatever else).

Nice, that makes things a bit simpler!

I think I've managed to find fixes to the various bugs – will break them up into individual subtasks shortly.

Is this resolved now then?
Are you waiting to deploy it on toolsbeta? (that'd be nice)

In T323681#8438313, @dcaro wrote:

Is this resolved now then?

The bugs are resolved and merged, but I want to add some tests as well before closing this task.

Are you waiting to deploy it on toolsbeta? (that'd be nice)

Yes – let's do a deploy! Maybe at the end of this iteration?

Yes – let's do a deploy! Maybe at the end of this iteration?

I would say as soon as you want :) (probably the end of this iteration being the latest)