Page MenuHomePhabricator

[tbs.cli] Options of external subcommands are not forwarded
Open, Needs TriagePublic1 Estimated Story Points

Description

Running commands such as toolforge <external-subcommand> -p or toolforge <external-subcommand> -n 10 fail, even if the options used in the examples are valid ones. Any options not specified as a @click.option decorator are simply ignored.

A solution would be to forward all unknown options for further manual processing to toolforge_cli.cli._run_external_command(), which handles all options and args just fine in its current implementation. https://click.palletsprojects.com/en/8.1.x/advanced/#forwarding-unknown-options

Event Timeline

Slst2020 set the point value for this task to 1.Wed, Nov 23, 4:42 PM

Change 860852 had a related patch set uploaded (by Slavina Stefanova; author: Slavina Stefanova):

[cloud/toolforge/toolforge-cli@main] cli: Pass through flags to external subcommands

https://gerrit.wikimedia.org/r/860852