Apparently, stylize was a tool to apply some MediaWiki code style conventions to PHP or JavaScript code, presumably before we used PHPCS and ESLint. The last commit to the source code repository was over eight years ago, and it looks like the tool has been broken since at least the toolforge.org migration (the frontend POSTs to https://stylize.toolforge.org/stylize/jsonapi.php – notice the repeated tool name in the path – which 404s) without anybody noticing. Let’s shut it down?
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove stylize.php | mediawiki/tools/code-utils | master | +0 -357 |
Related Objects
Related Objects
- Mentioned In
- T326292: Remove check-vars.php from code-utils
Event Timeline
Comment Actions
(I came across stylize in the PHP coding conventions, where it was still listed as the standard tool ahead of PHPCS; I’ve fixed that now.)
Comment Actions
While the included PHP file in that repo doesn't seem to exist inside the repo, I suspect on the actual Toolforge server this is probably using a copy of, or fork of, stylize.php from https://gerrit.wikimedia.org/g/mediawiki/tools/code-utils. Tagging as such.
I support removal/decom.
Comment Actions
Change 869859 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/tools/code-utils@master] Remove stylize.php
Comment Actions
Change 869859 merged by jenkins-bot:
[mediawiki/tools/code-utils@master] Remove stylize.php
Comment Actions
The Toolforge is about 10 years newer than the code-utils code. Afaik it was never used by MW contributors, and assume for now it is unrelated. It appears to have its own copy of the script, although I can't tell since the repo contains a symlink to a private path under /home/rillke beyond the scope of what was open sourced. Ping @Rillke for awareness. Feel free to keep running it however you see fit. If it does use a clone of the code-utils repo, then you may want to copy it into your repo for now.